Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/307: Add a fastpath(for certs that are already in memory) while fetching certificates. #311

Merged
merged 6 commits into from
Jul 4, 2023
Merged

issues/307: Add a fastpath(for certs that are already in memory) while fetching certificates. #311

merged 6 commits into from
Jul 4, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 4, 2023

komuw added 5 commits July 4, 2023 19:00
@komuw
go test -run=XXXX -bench=BenchmarkGetCertificate -count=100 github.co…
fb98f7e 
…m/komuw/ong/internal/acme > old.txt

go test -run=XXXX -bench=BenchmarkGetCertificate -count=100 github.com/komuw/ong/internal/acme > new.txt

benchstat old.txt new.txt

goos: linux
goarch: amd64
pkg: github.com/komuw/ong/internal/acme
cpu: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
                     │   old.txt   │           new.txt            │
                     │   sec/op    │   sec/op     vs base         │
GetCertificate/new-8   2.325µ ± 1%   1.871µ ± 1%  -19.53% (n=100)

                     │  old.txt   │          new.txt           │
                     │    B/op    │    B/op     vs base        │
GetCertificate/new-8   720.0 ± 0%   672.0 ± 0%  -6.67% (n=100)

                     │  old.txt   │           new.txt           │
                     │ allocs/op  │ allocs/op   vs base         │
GetCertificate/new-8   9.000 ± 0%   8.000 ± 0%  -11.11% (n=100)
@komuw
m
9cd0a36
@komuw
m
d3ca8a6
@komuw
m
bb59774
@komuw
m
6fdf9be
@komuw komuw marked this pull request as ready for review July 4, 2023 16:18
@komuw komuw merged commit baaa4cb into main Jul 4, 2023
@komuw komuw deleted the issues/307 branch July 4, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ong/acme: GetCertificate should have a fast path
1 participant
@komuw