Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/305: Refuse to fetch certificates for IP addresses #306

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 3, 2023

@komuw komuw marked this pull request as ready for review July 3, 2023 19:32
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.04 ⚠️

Comparison is base (664be60) 73.83% compared to head (4287b0a) 73.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   73.83%   73.79%   -0.04%     
==========================================
  Files          42       42              
  Lines        4804     4809       +5     
==========================================
+ Hits         3547     3549       +2     
- Misses       1008     1010       +2     
- Partials      249      250       +1     
Impacted Files Coverage Δ
internal/acme/acme.go 63.72% <85.71%> (+0.62%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 257b8a5 into main Jul 3, 2023
@komuw komuw deleted the issues/305 branch July 3, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ong/acme: dont request certificate for IP address.
2 participants