Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/296: Fix bug where acme certificates were not cached in memory #304

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 2, 2023

@komuw komuw changed the title issues/296: issues/296: Fix bug where acme certificates were not cached in memory Jul 2, 2023
@komuw komuw marked this pull request as ready for review July 2, 2023 14:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.08 🎉

Comparison is base (e4c4d8f) 73.64% compared to head (3f848c6) 73.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   73.64%   73.73%   +0.08%     
==========================================
  Files          42       42              
  Lines        4799     4804       +5     
==========================================
+ Hits         3534     3542       +8     
+ Misses       1015     1011       -4     
- Partials      250      251       +1     
Impacted Files Coverage Δ
internal/acme/acme.go 62.41% <ø> (-0.69%) ⬇️
server/tls_conf.go 57.53% <85.71%> (+10.47%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 664be60 into main Jul 2, 2023
@komuw komuw deleted the issues/296 branch July 2, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ong/acme: certs from memory dont seem to work.
2 participants