Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/296: Tighten check cert validity script #303

Merged
merged 10 commits into from
Jul 2, 2023
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 2, 2023

@komuw komuw changed the title Issues/296 cert mem issues/296: Tighten check cert validity script Jul 2, 2023
@komuw komuw marked this pull request as ready for review July 2, 2023 14:05
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.24 🎉

Comparison is base (8b1a122) 73.39% compared to head (0eda3b9) 73.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   73.39%   73.64%   +0.24%     
==========================================
  Files          42       42              
  Lines        4792     4799       +7     
==========================================
+ Hits         3517     3534      +17     
+ Misses       1022     1015       -7     
+ Partials      253      250       -3     
Impacted Files Coverage Δ
internal/acme/acme.go 63.10% <100.00%> (+0.68%) ⬆️
internal/acme/helpers.go 64.90% <100.00%> (+4.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit e4c4d8f into main Jul 2, 2023
@komuw komuw deleted the issues/296-cert-mem branch July 2, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants