Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests fast by pinging port #299

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Make tests fast by pinging port #299

merged 3 commits into from
Jul 2, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jul 2, 2023

No description provided.

@komuw komuw marked this pull request as ready for review July 2, 2023 07:24
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 86.20% and project coverage change: -0.06 ⚠️

Comparison is base (3153948) 73.43% compared to head (fa4040b) 73.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   73.43%   73.37%   -0.06%     
==========================================
  Files          42       42              
  Lines        4792     4782      -10     
==========================================
- Hits         3519     3509      -10     
  Misses       1021     1021              
  Partials      252      252              
Impacted Files Coverage Δ
internal/acme/http_client.go 69.18% <50.00%> (ø)
internal/acme/acme.go 63.10% <81.25%> (-0.13%) ⬇️
internal/acme/client.go 59.75% <100.00%> (-0.56%) ⬇️
internal/acme/helpers.go 60.85% <100.00%> (-0.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit dbeae29 into main Jul 2, 2023
@komuw komuw deleted the ping branch July 2, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants