Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add own ACME client implementation #294

Merged
merged 4 commits into from
Jul 1, 2023
Merged

Add own ACME client implementation #294

merged 4 commits into from
Jul 1, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 26, 2023

  • This was necessary in order to exact control on that process and also so as to enhance debugging experience for ACME failures.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage: 61.54% and project coverage change: -5.41 ⚠️

Comparison is base (a97aa95) 78.79% compared to head (3113fb3) 73.39%.

❗ Current head 3113fb3 differs from pull request most recent head 1cb911d. Consider uploading reports for the commit 1cb911d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   78.79%   73.39%   -5.41%     
==========================================
  Files          39       42       +3     
  Lines        3556     4792    +1236     
==========================================
+ Hits         2802     3517     +715     
- Misses        622     1022     +400     
- Partials      132      253     +121     
Impacted Files Coverage Δ
id/uuid.go 86.95% <ø> (ø)
server/cert.go 32.15% <0.00%> (ø)
server/tls_conf.go 47.05% <27.27%> (-2.20%) ⬇️
internal/acme/kind.go 34.09% <34.09%> (ø)
internal/acme/client.go 60.30% <60.30%> (ø)
internal/acme/helpers.go 61.00% <61.00%> (ø)
internal/acme/acme.go 62.54% <62.54%> (ø)
internal/acme/http_client.go 69.18% <69.18%> (ø)
middleware/middleware.go 100.00% <100.00%> (ø)
mux/mux.go 80.24% <100.00%> (+4.12%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw changed the title m Add own ACME client implementation Jun 29, 2023
@komuw komuw changed the base branch from ok-stuff to main June 29, 2023 20:15
@komuw komuw force-pushed the own-acme branch 3 times, most recently from f0b6513 to 779a030 Compare July 1, 2023 18:21
@komuw komuw marked this pull request as ready for review July 1, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants