Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/284: Use one server for ACME and app #287

Merged
merged 4 commits into from
Jun 22, 2023
Merged

issues/284: Use one server for ACME and app #287

merged 4 commits into from
Jun 22, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 22, 2023

  • Use one server to handle ACME challenge requests and normal application requests.
    Prior to this, we had an app server and an ACME server that were both listening on the same port.
    This used to cause the two to clash since requests for one might end up been handled by http handlers for the other.

  • Fixes: Acme server clashes with redirect server on port 80 #284

@komuw komuw marked this pull request as ready for review June 22, 2023 09:46
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 46.66% and project coverage change: +0.39 🎉

Comparison is base (abf6729) 76.87% compared to head (9f8d319) 77.27%.

❗ Current head 9f8d319 differs from pull request most recent head 98ba1a0. Consider uploading reports for the commit 98ba1a0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   76.87%   77.27%   +0.39%     
==========================================
  Files          36       36              
  Lines        3460     3458       -2     
==========================================
+ Hits         2660     2672      +12     
+ Misses        672      652      -20     
- Partials      128      134       +6     
Impacted Files Coverage Δ
middleware/middleware.go 95.45% <9.09%> (-4.55%) ⬇️
server/tls_conf.go 56.37% <41.66%> (+9.66%) ⬆️
client/client.go 84.07% <100.00%> (+0.28%) ⬆️
server/server.go 75.40% <100.00%> (+0.30%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 7f18d80 into main Jun 22, 2023
@komuw komuw deleted the issues/284 branch June 22, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acme server clashes with redirect server on port 80
2 participants