Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/285: Improve timeouts #286

Merged
merged 2 commits into from
Jun 22, 2023
Merged

issues/285: Improve timeouts #286

merged 2 commits into from
Jun 22, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 22, 2023

@komuw komuw marked this pull request as ready for review June 22, 2023 06:22
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 44.44% and project coverage change: -0.21 ⚠️

Comparison is base (abf6729) 76.87% compared to head (e276f01) 76.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   76.87%   76.67%   -0.21%     
==========================================
  Files          36       36              
  Lines        3460     3473      +13     
==========================================
+ Hits         2660     2663       +3     
- Misses        672      678       +6     
- Partials      128      132       +4     
Impacted Files Coverage Δ
middleware/middleware.go 95.45% <9.09%> (-4.55%) ⬇️
client/client.go 84.07% <100.00%> (+0.28%) ⬆️
server/tls_conf.go 46.70% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 3f06025 into main Jun 22, 2023
@komuw komuw deleted the issues/285 branch June 22, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ong/client: maybe dont set http.Client.Timeout
2 participants