Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/267: add mux Resolve function #268

Merged
merged 14 commits into from
Jun 7, 2023
Merged

issues/267: add mux Resolve function #268

merged 14 commits into from
Jun 7, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 7, 2023

What:

  • Add mux Resolve function
  • Imagine a customer calls and says they tried to access the url https://localhost/check/888, they expected to see a photo of a shark instead they saw a photo of an egg. How do you know which code/handler you should go look at, out of 10_000 handlers?
  • It is inspired by django's resolve url utility[3].

Why:

  1. Fixes: mux: add url resolve function #267
  2. This enhances debugging.
  3. https://docs.djangoproject.com/en/4.2/ref/urlresolvers/#django.urls.resolve

@komuw komuw marked this pull request as ready for review June 7, 2023 12:39
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.48 🎉

Comparison is base (ce5ce80) 77.58% compared to head (feba7a9) 78.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   77.58%   78.06%   +0.48%     
==========================================
  Files          36       36              
  Lines        3337     3360      +23     
==========================================
+ Hits         2589     2623      +34     
+ Misses        623      612      -11     
  Partials      125      125              
Impacted Files Coverage Δ
mux/mux.go 76.11% <83.33%> (+4.96%) ⬆️
mux/route.go 98.26% <100.00%> (+11.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit bfa98d5 into main Jun 7, 2023
@komuw komuw deleted the issues/267-urlResolve branch June 7, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mux: add url resolve function
2 participants