Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/247: run all tests in CI #248

Merged
merged 7 commits into from
Mar 9, 2023
Merged

issues/247: run all tests in CI #248

merged 7 commits into from
Mar 9, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Mar 9, 2023

@komuw komuw marked this pull request as ready for review March 9, 2023 06:28
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch coverage: 81.32% and project coverage change: +0.46 🎉

Comparison is base (3cf7698) 77.59% compared to head (edd718e) 78.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   77.59%   78.05%   +0.46%     
==========================================
  Files          34       36       +2     
  Lines        3156     3268     +112     
==========================================
+ Hits         2449     2551     +102     
- Misses        593      597       +4     
- Partials      114      120       +6     
Impacted Files Coverage Δ
internal/clientip/client_ip.go 72.46% <ø> (ø)
server/cert.go 32.15% <0.00%> (-25.73%) ⬇️
server/server.go 79.82% <68.42%> (+34.66%) ⬆️
server/fingerprint.go 80.32% <80.32%> (ø)
middleware/fingerprint.go 80.76% <80.76%> (ø)
middleware/log.go 64.38% <100.00%> (+0.49%) ⬆️
middleware/middleware.go 100.00% <100.00%> (ø)
middleware/recoverer.go 89.18% <100.00%> (+0.30%) ⬆️
server/tls_conf.go 66.94% <100.00%> (+16.51%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit d4b1451 into main Mar 9, 2023
@komuw komuw deleted the issues/247 branch March 9, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run all tests in ci, ie remove os.Getenv("GITHUB_ACTIONS")
2 participants