issues/235: Improve precision to ratelimiting #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
komuw
commented
Mar 2, 2023
•
komuw
commented
- Fixes: ratelimiting starts too early #235
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 77.59% 77.59%
=======================================
Files 34 34
Lines 3156 3156
=======================================
Hits 2449 2449
Misses 593 593
Partials 114 114
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
komuw
commented
Mar 2, 2023
middleware/ratelimiter.go
Outdated
Comment on lines
143
to
148
| if alw { | ||
| t.messagesDelivered = t.messagesDelivered + 1 | ||
| t.tokens = t.tokens - 1 | ||
| } else { | ||
| t.limit() | ||
| } |
There was a problem hiding this comment.
One effect of this new change is that if rate_limit = 100/sec and then you send requests that are equal to or less than 100, all of them will be let in immediately without delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.