Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/223: create dev certs if do not exists or expired #224

Merged
merged 23 commits into from
Feb 23, 2023
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented Feb 23, 2023

What:

  • Create dev certs only if they do not exists or are expired.

Why:

@komuw komuw marked this pull request as ready for review February 23, 2023 13:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Base: 72.60% // Head: 71.07% // Decreases project coverage by -1.53% ⚠️

Coverage data is based on head (5a99efe) compared to base (ece5804).
Patch coverage: 54.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   72.60%   71.07%   -1.53%     
==========================================
  Files          33       34       +1     
  Lines        2241     2247       +6     
==========================================
- Hits         1627     1597      -30     
- Misses        532      572      +40     
+ Partials       82       78       -4     
Impacted Files Coverage Δ
id/id.go 80.00% <0.00%> (+5.00%) ⬆️
middleware/client_ip.go 100.00% <ø> (ø)
server/cert.go 1.60% <0.00%> (-0.46%) ⬇️
server/server.go 46.66% <5.55%> (+1.10%) ⬆️
server/pprof.go 86.84% <66.66%> (-0.34%) ⬇️
log/log.go 83.33% <83.05%> (+1.93%) ⬆️
middleware/recoverer.go 90.62% <90.00%> (ø)
middleware/log.go 64.15% <94.11%> (-15.20%) ⬇️
client/client.go 88.73% <100.00%> (+0.32%) ⬆️
middleware/loadshed.go 74.50% <100.00%> (+5.88%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw changed the title issues/223: create dev certs if not exists or expired issues/223: Create dev certs only if they do not exists or are expired Feb 23, 2023
@komuw komuw changed the title issues/223: Create dev certs only if they do not exists or are expired issues/223: create dev certs if do not exists or expired Feb 23, 2023
@komuw komuw merged commit 2fc108b into main Feb 23, 2023
@komuw komuw deleted the issues/223 branch February 23, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only create dev certs if they are already expired(or close to expiry)
2 participants