Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/217: loadshedder should not re-order latencies. #218

Merged
merged 14 commits into from
Feb 6, 2023
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented Feb 6, 2023

@komuw komuw marked this pull request as ready for review February 6, 2023 09:17
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Base: 72.60% // Head: 72.81% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (8b9d191) compared to base (ece5804).
Patch coverage: 79.53% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   72.60%   72.81%   +0.21%     
==========================================
  Files          33       34       +1     
  Lines        2241     2218      -23     
==========================================
- Hits         1627     1615      -12     
+ Misses        532      524       -8     
+ Partials       82       79       -3     
Impacted Files Coverage Δ
id/id.go 80.00% <0.00%> (+5.00%) ⬆️
middleware/client_ip.go 100.00% <ø> (ø)
server/cert.go 2.07% <0.00%> (+0.01%) ⬆️
server/server.go 45.02% <4.16%> (-0.54%) ⬇️
server/pprof.go 80.48% <44.44%> (-6.70%) ⬇️
log/log.go 86.66% <86.48%> (+5.27%) ⬆️
middleware/recoverer.go 90.62% <90.00%> (ø)
middleware/log.go 64.15% <94.11%> (-15.20%) ⬇️
client/client.go 88.73% <100.00%> (+0.32%) ⬆️
middleware/loadshed.go 74.50% <100.00%> (+5.88%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 9b86540 into main Feb 6, 2023
@komuw komuw deleted the issues/217 branch February 6, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadshedder is slightly broken.
2 participants