Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace middleware #216

Merged
merged 32 commits into from
Feb 4, 2023
Merged

Add trace middleware #216

merged 32 commits into from
Feb 4, 2023

Conversation

komuw
Copy link
Owner

@komuw komuw commented Feb 4, 2023

  • This contains some of the logic that existed in the log middleware.
  • The log middleware now just logging.
  • The new trace middleware does the work of adding logID to request/response.
    This middleware is now the first middleware in the chain. This is necessary because there are other inner middlewares that depend on logIDs.

@komuw komuw changed the title Trace middleware Add trace middleware Feb 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Base: 72.76% // Head: 72.76% // No change to project coverage 👍

Coverage data is based on head (9f20d17) compared to base (2cdc95e).
Patch coverage: 93.82% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   72.76%   72.76%           
=======================================
  Files          34       34           
  Lines        2214     2214           
=======================================
  Hits         1611     1611           
  Misses        523      523           
  Partials       80       80           
Impacted Files Coverage Δ
client/client.go 88.73% <ø> (ø)
server/server.go 45.83% <0.00%> (ø)
log/log.go 86.66% <100.00%> (ø)
middleware/log.go 64.15% <100.00%> (ø)
middleware/middleware.go 100.00% <100.00%> (ø)
middleware/recoverer.go 90.62% <100.00%> (ø)
middleware/trace.go 100.00% <100.00%> (ø)
server/pprof.go 80.48% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw marked this pull request as ready for review February 4, 2023 13:58
@komuw komuw merged commit fc4d898 into main Feb 4, 2023
@komuw komuw deleted the trace-middleware branch February 4, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants