issues/211: re-enable golangci-lint

.github/workflows/ci.yml

@@ -130,7 +130,7 @@ jobs:
       - name: install tools
         run: |
           set -x
-          go install honnef.co/go/tools/cmd/staticcheck@master
+          go install honnef.co/go/tools/cmd/staticcheck@latest
           go install github.com/securego/gosec/cmd/gosec@latest
           go install github.com/quasilyte/go-ruleguard/cmd/ruleguard@latest
           go install github.com/orijtech/structslop/cmd/structslop@latest
@@ -175,7 +175,7 @@ jobs:
           wget -nc --output-document=/tmp/semgrep-go.zip https://github.com/dgryski/semgrep-go/archive/refs/heads/master.zip
           unzip -o /tmp/semgrep-go.zip -d /tmp/semgrep-go
           go get github.com/quasilyte/go-ruleguard/dsl
-          # golangci-lint run --config .golangci.yml ./...
+          golangci-lint run --config .golangci.yml ./...
           go mod tidy
           python -m venv /tmp/.venv
           . /tmp/.venv/bin/activate

CHANGELOG.md

@@ -6,6 +6,7 @@ Most recent version is listed first.
 ## v0.0.30
 - Update to Go v1.20: https://github.com/komuw/ong/pull/209
 - Use net.Dialer.ControlContext instead of use net.Dialer.Control: https://github.com/komuw/ong/pull/212
+- Re-enable golangci-lint: https://github.com/komuw/ong/pull/214
 
 ## v0.0.29
 - WithCtx should only use the id from context, if that ctx actually contains an Id: https://github.com/komuw/ong/pull/196

id/id.go

@@ -51,7 +51,7 @@ func Random(n int) string {
 		//lint:ignore SA1019 `mathRand.Read` is deprecated.
 		// However, for our case here is okay since the func id.Random is not used for cryptography.
 		// Also we like the property of `mathRand.Read` always returning a nil error.
-		_, _ = mathRand.Read(b) // docs say that it always returns a nil error.
+		_, _ = mathRand.Read(b) // nolint:staticcheck
 	}
 
 	return enc.EncodeToString(b)[:n]