Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/184: Use roundTripper for logging #185

Merged
merged 8 commits into from
Dec 8, 2022
Merged

issues/184: Use roundTripper for logging #185

merged 8 commits into from
Dec 8, 2022

Conversation

komuw
Copy link
Owner

@komuw komuw commented Dec 8, 2022

What:

  • Use roundTripper for logging

Why:

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 71.92% // Head: 72.22% // Increases project coverage by +0.29% 🎉

Coverage data is based on head (91e4a38) compared to base (3e5ff38).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   71.92%   72.22%   +0.29%     
==========================================
  Files          31       31              
  Lines        2109     2074      -35     
==========================================
- Hits         1517     1498      -19     
+ Misses        518      506      -12     
+ Partials       74       70       -4     
Impacted Files Coverage Δ
client/client.go 88.23% <100.00%> (+11.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 8a3a2b0 into main Dec 8, 2022
@komuw komuw deleted the issues/184 branch December 8, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ong/client: use roundTripper for logging
2 participants