Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ong/client: Add log id http header #166

Merged
merged 5 commits into from
Oct 24, 2022
Merged

ong/client: Add log id http header #166

merged 5 commits into from
Oct 24, 2022

Conversation

komuw
Copy link
Owner

@komuw komuw commented Oct 24, 2022

What:

  • ong/client: Add log id http header

Why:

  • context.Context is not propagated across network boundaries

@komuw komuw marked this pull request as ready for review October 24, 2022 19:55
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Base: 71.29% // Head: 71.58% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (5b3d46e) compared to base (e0cfdcf).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   71.29%   71.58%   +0.28%     
==========================================
  Files          30       30              
  Lines        2073     2069       -4     
==========================================
+ Hits         1478     1481       +3     
+ Misses        525      516       -9     
- Partials       70       72       +2     
Impacted Files Coverage Δ
client/client.go 76.69% <43.75%> (+5.67%) ⬆️
middleware/log.go 79.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw merged commit 2306e72 into main Oct 24, 2022
@komuw komuw deleted the add-logID-header branch October 24, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants