Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/156: fix false positive/negative/whatever route conflict #157

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

komuw
Copy link
Owner

@komuw komuw commented Oct 19, 2022

What:

  • fix false positive/negative/whatever route conflict

Why:

@codecov-commenter
Copy link

Codecov Report

Base: 71.12% // Head: 71.12% // No change to project coverage 👍

Coverage data is based on head (cdc2d70) compared to base (43b1e1f).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head cdc2d70 differs from pull request most recent head e47d48b. Consider uploading reports for the commit e47d48b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          30       30           
  Lines        2057     2057           
=======================================
  Hits         1463     1463           
+ Misses        525      524    -1     
- Partials       69       70    +1     
Impacted Files Coverage Δ
mux/route.go 85.54% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@komuw komuw marked this pull request as ready for review October 19, 2022 10:53
@komuw komuw merged commit 1563c56 into main Oct 19, 2022
@komuw komuw deleted the issues/156 branch October 19, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive/negative/whatever on route conflicts
2 participants