use http.Handler instead of http.HandlerFunc #266

komuw · 2023-06-07T05:04:07Z

https://github.com/komuw/ong/blob/v0.0.48/middleware/loadshed.go#L47

https://github.com/komuw/ong/blob/v0.0.48/mux/mux.go#L34

func oneMiddleware(wrappedHandler http.HandlerFunc) http.HandlerFunc {
	count := 0
	return func(w http.ResponseWriter, r *http.Request) {
		count = count + 1
		wrappedHandler(w, r)
	}
}

func twoMiddleware(wrappedHandler http.Handler) http.HandlerFunc {
	count := 0
	return func(w http.ResponseWriter, r *http.Request) {
		count = count + 1
		wrappedHandler.ServeHTTP(w, r)
	}
}

func threeMiddleware(wrappedHandler http.Handler) http.Handler {
	count := 0
	return http.HandlerFunc(
		func(w http.ResponseWriter, r *http.Request) {
			count = count + 1
			wrappedHandler.ServeHTTP(w, r)
		},
	)
}

Ideally we want threeMiddleware (I think).
We should benchmark them.

The text was updated successfully, but these errors were encountered:

…andlerFunc (#269) What: - Use `http.Handler` as the http middleware instead of `http.HandlerFunc` - With this change, a middleware accepts a `http.Handler` and returns a `http.HandlerFunc`. This is more in line with the mantra; `accept interfaces, return concrete types` Why: - `http.Handler` is a more idiomatic middleware since it is an interface whereas http.HandlerFunc is an implementation of that interface - Fixes #266 Benchmarks: func oneMiddleware(wrappedHandler http.HandlerFunc) http.HandlerFunc { count := 0 return func(w http.ResponseWriter, r *http.Request) { count = count + 1 r.Header.Set("MY-COUNT", fmt.Sprint(count)) wrappedHandler(w, r) } } func twoMiddleware(wrappedHandler http.Handler) http.HandlerFunc { count := 0 return func(w http.ResponseWriter, r *http.Request) { count = count + 1 r.Header.Set("MY-COUNT", fmt.Sprint(count)) wrappedHandler.ServeHTTP(w, r) } } func threeMiddleware(wrappedHandler http.Handler) http.Handler { count := 0 return http.HandlerFunc( func(w http.ResponseWriter, r *http.Request) { count = count + 1 r.Header.Set("MY-COUNT", fmt.Sprint(count)) wrappedHandler.ServeHTTP(w, r) }, ) } go test -benchmem -run=^$ -bench ^BenchmarkMid$ github.com/komuw/ong/mux -count=5 BenchmarkMid/oneMiddleware-8 358.7 ns/op BenchmarkMid/oneMiddleware-8 371.8 ns/op BenchmarkMid/oneMiddleware-8 343.6 ns/op BenchmarkMid/oneMiddleware-8 289.0 ns/op BenchmarkMid/oneMiddleware-8 291.4 ns/op BenchmarkMid/twoMiddleware-8 296.7 ns/op BenchmarkMid/twoMiddleware-8 353.3 ns/op BenchmarkMid/twoMiddleware-8 363.2 ns/op BenchmarkMid/twoMiddleware-8 366.2 ns/op BenchmarkMid/twoMiddleware-8 315.2 ns/op BenchmarkMid/threeMiddleware-8 299.0 ns/op BenchmarkMid/threeMiddleware-8 307.6 ns/op BenchmarkMid/threeMiddleware-8 324.9 ns/op BenchmarkMid/threeMiddleware-8 367.6 ns/op BenchmarkMid/threeMiddleware-8 373.3 ns/op The change we want is `twoMiddleware` and it seems competitive with the others.

komuw mentioned this issue Jun 7, 2023

issues/266: use http.Handler as the http middleware instead of http.HandlerFunc #269

Merged

komuw closed this as completed in #269 Jun 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use http.Handler instead of http.HandlerFunc #266

use http.Handler instead of http.HandlerFunc #266

komuw commented Jun 7, 2023 •

edited

Loading

use http.Handler instead of http.HandlerFunc #266

use http.Handler instead of http.HandlerFunc #266

Comments

komuw commented Jun 7, 2023 • edited Loading

komuw commented Jun 7, 2023 •

edited

Loading