Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/157: add heartbeat to BreachHandler #161

Merged
merged 20 commits into from
Sep 6, 2019
Merged

issues/157: add heartbeat to BreachHandler #161

merged 20 commits into from
Sep 6, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Sep 5, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • Add heartbeat to BreachHandler

Why(Why did you change it?)

  • Fixes: BreachHandler should have heartbeat #157
  • When using BreachHandler , it may be important to periodically make sure that your logging pipeline works even when there is nothing to log since there hasn't been a breach.
    In such a case you can enable heartbeats

References:

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #161 into master will decrease coverage by 0.2%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   86.49%   86.29%   -0.21%     
==========================================
  Files          14       14              
  Lines        1311     1321      +10     
==========================================
+ Hits         1134     1140       +6     
- Misses        177      181       +4
Impacted Files Coverage Δ
naz/log.py 87.2% <60%> (-3.59%) ⬇️
naz/hooks.py 79.16% <0%> (ø) ⬆️
naz/client.py 80.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8201cee...81bb679. Read the comment docs.

@komuw komuw changed the title issues/157 issues/157: add heartbeat to BreachHandler Sep 6, 2019
@komuw komuw merged commit 65ac56c into master Sep 6, 2019
@komuw komuw deleted the issues/157 branch September 6, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BreachHandler should have heartbeat
2 participants