Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/112 #124

Merged
merged 29 commits into from
Jun 1, 2019
Merged

issues/112 #124

merged 29 commits into from
Jun 1, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented May 31, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • During startup; for both enquire_link and submit_sm, wait until the session state transtions to naz.SmppSessionState.BOUND_TRX before sending out messages

Why(Why did you change it?)

References:

@komuw komuw changed the base branch from issues/104 to master June 1, 2019 05:34
@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #124 into master will decrease coverage by 0.04%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   86.16%   86.12%   -0.05%     
==========================================
  Files          14       14              
  Lines        1200     1196       -4     
==========================================
- Hits         1034     1030       -4     
  Misses        166      166
Impacted Files Coverage Δ
cli/cli.py 87.5% <ø> (+19.24%) ⬆️
naz/client.py 80.38% <70.58%> (-1.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f0345...929cf93. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: smpp_command: submit_sm cannot be sent to SMSC when the client session state is: OPEN
2 participants