Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/104 #123

Merged
merged 10 commits into from
Jun 1, 2019
Merged

Issues/104 #123

merged 10 commits into from
Jun 1, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented May 31, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • replace naz json config file with a python file.

Why(Why did you change it?)

References:

@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #123 into master will increase coverage by 1.02%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   85.13%   86.16%   +1.02%     
==========================================
  Files          13       14       +1     
  Lines        1238     1200      -38     
==========================================
- Hits         1054     1034      -20     
+ Misses        184      166      -18
Impacted Files Coverage Δ
cli/cli.py 68.25% <100%> (-0.92%) ⬇️
cli/utils/load.py 89.47% <89.47%> (ø)
naz/client.py 82.34% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f34f83...8348550. Read the comment docs.

@komuw komuw merged commit b1f0345 into master Jun 1, 2019
@komuw komuw deleted the issues/104 branch June 1, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace naz json config file with a python file.
2 participants