Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/110:: remove ability to bring your own eventloop #111

Merged
merged 60 commits into from
May 28, 2019
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented May 27, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • remove ability to bring your own eventloop

Why(Why did you change it?)

  • Python eco-system is moving(in my opinion) towards a place where people use the standard eventloop that ships with python. We should also move towards that
  • This also makes naz easier to maintain
  • Fixes: remove ability to bring your own loop #110

References:

@komuw komuw changed the title Issues/110 Issues/110:: remove ability to bring your own eventloop May 27, 2019
@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #111 into master will increase coverage by 1.53%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   81.05%   82.59%   +1.53%     
==========================================
  Files          13       13              
  Lines        1193     1189       -4     
==========================================
+ Hits          967      982      +15     
+ Misses        226      207      -19
Impacted Files Coverage Δ
naz/throttle.py 86.76% <ø> (+1.47%) ⬆️
cli/cli.py 69.49% <0%> (ø) ⬆️
naz/q.py 78.94% <100%> (+2.75%) ⬆️
naz/ratelimiter.py 93.02% <100%> (+2.32%) ⬆️
naz/client.py 76.02% <100%> (+1.51%) ⬆️
naz/hooks.py 79.16% <0%> (ø) ⬆️
cli/utils/sig.py 87.5% <0%> (+43.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19744b...74314f5. Read the comment docs.

@komuw komuw merged commit 5ebeffe into master May 28, 2019
@komuw komuw deleted the issues/110 branch May 28, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove ability to bring your own loop
2 participants