Support for the changed schema of Nominatim's interpolation tables #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interpolation table now uses a step column instead of the interpolationtype. Check at the beginning which column is available and support both formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table with house number interpolations in Nominatim has changed its style replacing the
interpolationtypewith a simplerstepcolumn and excluding duplicate house numbers with the placex tables. See osm-search/Nominatim#2597 for details.This PR adds support for the new style while keeping compatibility with the old style. Photon checks on startup which of the columns is available and uses the appropriate SQL for getting the data.
The change highlighted an issue we've been having for a while: the API endpoint to update Nominatim is always available, no matter if Nominatim is installed. Given that most users never want to run updates via Photon, this isn't an API that should be there unless explicitly requested. The PR adds a new command-line option
-enable-update-apiwhich needs to be added to set up the update endpoint. This is a change in behaviour for everybody who runs updates. You need to add the new option to continue to run updates.