Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with XDRgen for Elixir #9

Merged
merged 12 commits into from
May 9, 2023
Merged

Fixing issues with XDRgen for Elixir #9

merged 12 commits into from
May 9, 2023

Conversation

elisa6
Copy link

@elisa6 elisa6 commented May 8, 2023

After reviewing the next files .x from Stellar Core:

We need to fix the next issues:

  • Not generate duplicate files
  • The arms for a union need to be a map when the arms are integers
  • Not repeat alias and types in unions
  • The max length for the variable lists must be included in the module name and file name
  • Include the Fixed prefix when is a fixed list
  • Fix module name from Opaque types

@elisa6 elisa6 requested a review from miguelnietoa May 8, 2023 21:54
@elisa6 elisa6 requested a review from miguelnietoa May 9, 2023 15:04
@elisa6 elisa6 merged commit bfe5578 into elixir_support May 9, 2023
@elisa6 elisa6 deleted the fix-issues branch May 9, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants