Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Add check-name options #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

liskin
Copy link

@liskin liskin commented Sep 28, 2020

Without this, the check isn't very useful in a build matrix as the last
build overwrites the results.

Without this, the check isn't very useful in a build matrix as the last
build overwrites the results.
if (res) {
res.pop(); // drop last quote
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR really, but my browser shows me tabs-vs-spaces in github diffs, and this file has a [un]healthy mix of both. Could be nice to add an .editorconfig or something that keeps things consistent, perhaps?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change comes from the ce733af commit and was generated by running yarnpkg run package. You don't think I should be fixing whitespace in the generated dist/index.js file do you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I certainly don't 😉

@liskin
Copy link
Author

liskin commented Sep 29, 2020

I see you're spending some time reviewing this PR, so it's only fair that I warn you that I will most likely not be using mypy-actions after all due to limitations in GitHub Actions: actions/toolkit#133 (comment) and I will try to find or create an Action that uses Problem Matchers instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants