This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Forbidden error #187
Merged
Forbidden error #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe something like this? https://github.com/hashicorp/go-multierror |
|
Good discussion of the issue here pkg/errors#15 |
allow batching of permission errors refactor some of the error handling in encodeError clean up some of the error messages
marpaia
approved these changes
Sep 23, 2016
| @@ -17,7 +17,7 @@ func authenticated(next endpoint.Endpoint) endpoint.Endpoint { | |||
| return nil, err | |||
| } | |||
| if !vc.IsLoggedIn() { | |||
| return nil, forbiddenError{message: "must be logged in"} | |||
| return nil, authError{reason: "must be logged in", clientReason: "must be logged in"} | |||
There was a problem hiding this comment.
I assume this is auth error and all the rest are permission errors because auth errors only apply to the authentication process whereas authorization errors and represented by permissionError?
There was a problem hiding this comment.
That's right. One ends up in a 401 and the other in a 403 on the client.
The user will get an authentication error if they haven't logged in or their credentials are invalid, and a permission error if they're already auth'd but not allowed to do something.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is getting pretty ugly, I'll have to find a better way.
The biggest issue right now, is that on a PATCH request, there could be multiple fields that are denied for different reasons. Validation errors have a similar issue.
Typically, you want to bail right away if an error occurs, and when we log that error it's fine.
Here, I want to validate the whole input and build up a list of failed properties and reasons.
Maybe I'm not thinking about it the right way.
JSON output