Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysqldump] Updated Bitnami MariaDB chart version #110

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

cpjolly
Copy link
Contributor

@cpjolly cpjolly commented Jun 22, 2022

Which chart

What this PR does / why we need it

Bitnami have removed version 9 of the MariaDB Helm Chart and have replaced it with version 11.
Also, setting the dependency to 11.x.x rather than a specific number ensures that the latest version 11 commit is always used.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • All variables are documented in the charts README

@sschnabe sschnabe requested a review from monotek June 29, 2022 13:32
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart Version needed to be raised.

Please use a real appversion.

@cpjolly
Copy link
Contributor Author

cpjolly commented Jun 30, 2022

Hi @monotek

  • You want me to bump the version field from 5.0.0 to 5.0.1 or 5.1.0 or 6.0.0 ?
  • The last change to appVersion was 2 years ago by you from 2.4.1 to 3.0.0. Do you want 3.0.1, 3.1.0, 3.9.0 or 4.0.0 ?

@monotek
Copy link
Member

monotek commented Jun 30, 2022

Please follow: https://semver.org/

@monotek monotek force-pushed the main branch 2 times, most recently from e0d2636 to 744ce03 Compare June 30, 2022 11:45
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some changes. Please sign your commit to get the DCO check work.

@cpjolly
Copy link
Contributor Author

cpjolly commented Jul 4, 2022

@monotek - I have tried to sign my commit. Apologies if this is incorrect.

Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nzolot and others added 2 commits July 4, 2022 13:57
* Added ability to specify securityContext

Signed-off-by: Nick Zolotarov <[email protected]>

* Update README.md

Signed-off-by: Nick Zolotarov <[email protected]>

* [fluentd-elasticsearch] Added ability to specify securityContext (kokuwaio#93) - version bump

Signed-off-by: Nick Zolotarov <[email protected]>

Co-authored-by: André Bauer <[email protected]>
Signed-off-by: Chris <[email protected]>
@cpjolly
Copy link
Contributor Author

cpjolly commented Jul 4, 2022

Thanks @monotek - I've uploaded a second attempt to sign, based on the link you shared. Lets see if that works...

@monotek monotek merged commit 9eae38b into kokuwaio:main Jul 4, 2022
@cpjolly
Copy link
Contributor Author

cpjolly commented Jul 4, 2022

many thanks @monotek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants