Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: double click to open NSFW media #392

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

qwreey
Copy link
Contributor

@qwreey qwreey commented Nov 2, 2023

What

Add option to change nsfw media open behavior: double click to open NSFW media

SmartSelect_20231103_045830_Kiwi Browser

Why

To prevent mistakely open NSFW media

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@qwreey
Copy link
Contributor Author

qwreey commented Nov 2, 2023

Also should applied to video component (i will update pr when i can)

@qwreey
Copy link
Contributor Author

qwreey commented Nov 2, 2023

  • MkMediaVideo
  • MkMediaImage
Screen_Recording_20231103_083646_Kiwi.Browser.mp4

@qwreey qwreey marked this pull request as ready for review November 2, 2023 23:42
@qwreey
Copy link
Contributor Author

qwreey commented Nov 2, 2023

Note: Modifying clickedIndex to -1 is a safe way to block opening PhotoSwipe. have no side-effects (packages/frontend/src/components/MkMediaList.vue)
Copied_Item_1698969277884

@noridev
Copy link
Collaborator

noridev commented Nov 3, 2023

🙏🙏🙏

@noridev noridev merged commit 1dc0f88 into kokonect-link:develop Nov 3, 2023
1 check passed
@noridev noridev mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants