[Fix] Ufuncs: Support float32 scalars for Add, Multply, and Divide #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation does not support float32 scalars for
add
,multiply
, anddivide
. This PR introduces a simple fix in the logic to allow computation withfloat32
scalars.Currently Pykokkos always casts scalars as
pk.double
which is equivalent tofloat64
in numpy terms. We also then enforce that both operands, for the aforementioned ufuncs, be the same type .e.g. eitherfloat32
orfloat64
. This creates a problem when passing afloat32
value as scalar with afloat32
view. The scalar is casted asfloat64
and the type assertion fails by our own doing.To fix this:
Float32
orfloat64
based on the view it is passed with (so they remain the same)float
impls to use modulus indexing to support scalarsQuality tweak: