Skip to content

Commit

Permalink
Fix Kokkos header includes (#45)
Browse files Browse the repository at this point in the history
* Fix Kokkos header includes

* pin `setuptools` version like other projects do--for
projects with compiled extensions newer `setuptools` is often
problematic

Co-authored-by: Tyler Reddy <[email protected]>
  • Loading branch information
dalg24 and tylerjereddy authored Aug 31, 2022
1 parent 87290b3 commit 3402d93
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 17 deletions.
4 changes: 0 additions & 4 deletions cmake/Modules/KokkosPythonPackages.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,7 @@ IF(ENABLE_PRECOMPILED_HEADERS)
TARGET_PRECOMPILE_HEADERS(libpykokkos-precompiled-headers
INTERFACE
<Kokkos_Core.hpp>
<Kokkos_View.hpp>
<Kokkos_Layout.hpp>
<Kokkos_Core_fwd.hpp>
<Kokkos_DynRankView.hpp>
<Kokkos_MemoryTraits.hpp>
)

# pybind11 headers
Expand Down
6 changes: 1 addition & 5 deletions cmake/Templates/KokkosExp_InterOp.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,8 @@
#ifndef KOKKOS_CORE_EXP_INTEROP_HPP
#define KOKKOS_CORE_EXP_INTEROP_HPP

#include <Kokkos_Core_fwd.hpp>
#include <Kokkos_Layout.hpp>
#include <Kokkos_MemoryTraits.hpp>
#include <Kokkos_View.hpp>
#include <Kokkos_Core.hpp>
#include <Kokkos_DynRankView.hpp>
#include <impl/Kokkos_Utilities.hpp>
#include <type_traits>

namespace Kokkos {
Expand Down
1 change: 0 additions & 1 deletion include/deep_copy.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@

#include <Kokkos_Core.hpp>
#include <Kokkos_DynRankView.hpp>
#include <Kokkos_View.hpp>

//----------------------------------------------------------------------------//

Expand Down
2 changes: 0 additions & 2 deletions include/fwd.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@
#include "defines.hpp"

#include <Kokkos_Core.hpp>
#include <Kokkos_Layout.hpp>
#include <Kokkos_MemoryTraits.hpp>

#include <set>
#include <string>
Expand Down
4 changes: 1 addition & 3 deletions include/traits.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@
#include "defines.hpp"
#include "fwd.hpp"

#include <Kokkos_Core_fwd.hpp>
#include <Kokkos_Layout.hpp>
#include <Kokkos_MemoryTraits.hpp>
#include <Kokkos_Core.hpp>

//----------------------------------------------------------------------------//

Expand Down
1 change: 0 additions & 1 deletion include/views.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@

#include <Kokkos_Core.hpp>
#include <Kokkos_DynRankView.hpp>
#include <Kokkos_View.hpp>

//----------------------------------------------------------------------------//

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[build-system]
requires = [
"setuptools >= 40.0.4",
"setuptools < 60.0.0",
"setuptools_scm >= 2.0.0",
"wheel >= 0.29.0",
"scikit-build >= 0.8.0",
Expand Down

0 comments on commit 3402d93

Please sign in to comment.