Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DualView::need_sync should be a const method #248

Closed
mhoemmen opened this issue Apr 25, 2016 · 2 comments
Closed

DualView::need_sync should be a const method #248

mhoemmen opened this issue Apr 25, 2016 · 2 comments
Assignees
@mhoemmen
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@mhoemmen
Copy link
Contributor

DualView::need_sync should be a const method, because it does not actually sync, reallocate, mark anything modified, or otherwise modify any state.
@mhoemmen
Copy link
Contributor Author

I'm working on a fix now. It's easy.

crtrott added a commit that referenced this issue Apr 26, 2016
@crtrott
Merge pull request #249 from mhoemmen/develop
c068eae 
DualView: Fix #248 (make need_sync const)
@crtrott crtrott added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) bug - fix pushed to develop branch labels Apr 26, 2016
@mhoemmen
Copy link
Contributor Author

Thanks Christian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhoemmen mhoemmen

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhoemmen @crtrott