LSP Server Support #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
commented
Mar 8, 2019
package.json
Outdated
| ], | ||
| "preferGlobal": true, | ||
| "main": "./lib/madoko.js", | ||
| "main": "./lib/api.js", |
There was a problem hiding this comment.
Here I changed the main file to access analyze instead of madoko. We need to change this to allow both.
There was a problem hiding this comment.
I merged the two interfaces and changed it back, so it should be mostly backwards compatible , modulo the change of the return type of markdown:
- (string,options)
+ (string,options,list<block>,formatContext)
b-studios
commented
Mar 8, 2019
| @@ -138,7 +138,7 @@ function parseDefinitionsFull( | |||
| // set label | |||
| if (attrsx.name != "") then { | |||
| val labelCaption = attrsx.hasKey("caption").maybe("",id) | |||
| labels[attrsx.name] := Label(bname,attrsx.label,labelCaption) | |||
| labels[attrsx.name] := Label(bname,attrsx.label,labelCaption,attrsx) | |||
There was a problem hiding this comment.
This was important to get the position information on the label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only for discussion and should (not yet) be merged
To implement an LSP Server for madoko, we need to extract some information about the document. This branch tries to simplify this process.