Use strlcpy() instead of strncpy() with -f arg

Add a safety check for argument length too
koitsu · Dec 21, 2017 · 813b283 · 813b283
1 parent 22b06c3
commit 813b283
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/main.c b/main.c
@@ -128,7 +128,11 @@ main(int argc, char *argv[])
 				comma_output = 1;
 				break;
 			case 'f':
-				strncpy(smbdev, optarg, MAXPATHLEN);
+				if (strlcpy(smbdev, optarg, MAXPATHLEN) >= MAXPATHLEN) {
+					warn("Device pathname exceeds %u bytes in length", MAXPATHLEN);
+					exitcode = EX_SOFTWARE;
+					goto finish;
+				}
 				break;
 			case 'l':
 				list_models(&boardlist);