-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradients synchronization for multi-GPUs training #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isotr0py
changed the title
Fix gradients synchronization
Fix gradients synchronization for multi-GPUs training
Dec 6, 2023
Thank you for this! I didn't test multi-gpu training, but the PR seems to be very important. |
This seems to have broken sampling -
|
kohya-ss
added a commit
that referenced
this pull request
Dec 15, 2023
@deepdelirious I've updated the dev branch. I didn't test with multiple GPUs, but I think it will fix the sampling. |
I dont see these in code where ? ddp_bucket_view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: About GPU utilization #965
Fix [Bug] Gradients not synchronized #924
Remove
train_util.transform_if_model_is_DDP
, this caused the gradients sync bug on DDP. Now model will be unwrapped byaccelerator.unwrap_model()
manually.Clean
accelerator.prepare()
codes intrain_network.py
Sync lora network gradients in
train_network.py
manually.For
train_network.py
, since we apply the lora through replacing theforward()
method instead of the module, the DDP lora won't sync gradients automatically when callingaccelerator.backward(loss)
. Hence we need to useaccelerator.reduce()
to sync grad manually.