Allow subclasses of CmdLineParser to override expandAtFiles behaviour #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -548,7 +548,7 @@ public void parseArgument(final String... args) throws CmdLineException { | |||
| * by the @ sequences, split around the line breaks. | |||
| * @throws CmdLineException | |||
| */ | |||
| private String[] expandAtFiles(String args[]) throws CmdLineException { | |||
| protected String[] expandAtFiles(String args[]) throws CmdLineException { | |||
| List<String> result = new ArrayList<String>(); | |||
There was a problem hiding this comment.
not clear why whole method needs to be overidable rather than just readAtFile. Since this method takes whole args list as parameter, makes it too easy to do generally bad things.
There was a problem hiding this comment.
Just in case. args4j has a habit of having private methods that result in me having to maintain my own fork. I wouldn't expect anyone to extend CmdLineParser unless then know what they're doing.
|
At the very least I want to be able to specify the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow subclasses of CmdLineParser to override expandAtFiles and how argument files are read and parsed.