CmdLineParser: mark createOptionHandler() as non-deprecated #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since b1aa90f the createOptionHandler() was deprecated and the user was routed to OptionHandlerRegistry method instead. As a side effect the overridding of the now deprecated method createOptionHandler() doesn't have any effect, because this method is not get called any more from the addOption() and addArgument() methods. The documented OptionHandlerRegistry.registerHandler() machinery cannot be used, when a DI framework is used and the instances must be created by the injector. Mark createOptionHandler as non deprecated again and use it from addOption() and addArgument() methods. This commit partial reverts b1aa90f
|
Kohsuke Kawaguchi » args4j #174 FAILURE |
|
Perhaps there is a better solution to this, for example making the registry a singleton via OptionHandlerRegistry.getOnlyInstance(), which would allow it to work with DI by binding the instance to the contract. |
|
Being able to override |
kohsuke
added a commit
that referenced
this pull request
Jan 30, 2016
CmdLineParser: mark createOptionHandler() as non-deprecated
sebasjm
pushed a commit
to sebasjm/args4j
that referenced
this pull request
Mar 11, 2018
CmdLineParser: mark createOptionHandler() as non-deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since b1aa90f the createOptionHandler() was
deprecated and the user was routed to OptionHandlerRegistry method
instead. As a side effect the overridding of the now deprecated method
createOptionHandler() doesn't have any effect, because this method is
not get called any more from the addOption() and addArgument() methods.
The documented OptionHandlerRegistry.registerHandler() machinery cannot
be used, when a DI framework is used and the instances must be created by
the injector.
Mark createOptionHandler as non deprecated again and use it from addOption()
and addArgument() methods.
This commit partial reverts b1aa90f