OptionHandler's getMetaVariable fails when used with ResourceBundle

[sannies]

the method checks if there is a localization for the metavar and assumes that ResourceBundle#getString(key) will return null when there is no key. But the getString method will throw a MissingResourceException instead. Therefore it is not possbile to use getString with L10N.

(sorry for re-format of the test class)

[buildhive]

Kohsuke Kawaguchi » args4j #168 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

[buildhive]

Kohsuke Kawaguchi » args4j #169 SUCCESS
This pull request looks good
(what's this?)

[buildhive]

Kohsuke Kawaguchi » args4j #172 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[buildhive]

Kohsuke Kawaguchi » args4j #173 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[kohsuke]

Unfortunately, too many whitespace changes make it difficult to review this diff

[buildhive]

Kohsuke Kawaguchi » args4j #177 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[buildhive]

Kohsuke Kawaguchi » args4j #178 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[sannies]

Sorry for creating such a sloppy pull request in the first place. I tidied up the pull request - it should be very easy to review now.
Latest build is failing due to hiccup on jenkins.

[javaerb]

can this be merged?

[sannies]

In my eyes it's ready to merge.

• Test is there.
• fixes an obvious problem as rb.getString(token) cannot be expected to return null according to JavaDoc (MissingResourceException - if no object for the given key can be found)
• The last build problem was only a hiccup on jenkins

[sannies]

Hi,
it there anything I can do to get this in? I'm still running on my patched branch.
Best Regards,
Sebastian