Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About page: no space between paragraphs, no underlining, colors for hyperlinks #18

Open
jhannah opened this issue May 13, 2024 · 0 comments · May be fixed by #19
Open

About page: no space between paragraphs, no underlining, colors for hyperlinks #18

jhannah opened this issue May 13, 2024 · 0 comments · May be fixed by #19

Comments

@jhannah
Copy link

jhannah commented May 13, 2024

Hello, thanks for your blog starter!

I'm new to liquid -> tailwind -> CSS, so I'm confused what I can change in this starter so that my About page has space between paragraphs, and hyperlinks are underlined / have colors.

Those tags work great inside posts, but the About page is somehow a special case where those problems appear.

Thanks!
jhannah added a commit to jhannah-netlify/brotherbemused that referenced this issue May 13, 2024
@jhannah
Use @tailwindcss/typography for About page too
e7755fd 
class "prose" comes from https://tailwindcss.com/docs/plugins#typography

And that's what's used in post bodies.

When we look at the table styling preview as documented by those developers

  https://play.tailwindcss.com/uj1vGACRJA?layout=preview

We see that this is the way they want tables to look.

So let's also use that for pages other than post pages for consistency.

Fixes kohrongying#18
@jhannah-netlify jhannah-netlify linked a pull request May 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use @tailwindcss/typography for About page too jhannah-netlify/brotherbemused
1 participant
@jhannah