add absolute file prefix for dynamic imports

[robertkiel]

Re #812

Main change

Always add the file:// prefix when loading ES moduls or CommonJS scripts.

Tested with:

• Windows 11 (natively, no WSL)
• Linux
• MacOS , see https://github.com/kogosoftwarellc/open-api/runs/6957151421?check_suite_focus=true

How to test

npm run bootstrap
cd packages/express-openapi
npm run test

[jsdevel]

thank you @robertkiel !

[7mllm7]

@robertkiel care you to explain the reason for this change?
This specific line basically fails my build (with webpack, when trying to bundle openapi-framework in a single bundle...).

I get:

ERROR in ./node_modules/openapi-framework/dist/index.js 132:47-84
Module not found: Error: Can't resolve 'file:/' in '/............./myproject/node_modules/openapi-framework/dist'

Which comes from exactly this line:

const imported = await import(`file://${fsRoutesItem.path}`);

If I remove the file:// bit, it's alright, but since you actually purposely added this, I don't want to change it.

Thanks!

[robertkiel]

@robertkiel care you to explain the reason for this change?
This specific line basically fails my build (with webpack, when trying to bundle openapi-framework in a single bundle...).

I get:

ERROR in ./node_modules/openapi-framework/dist/index.js 132:47-84
Module not found: Error: Can't resolve 'file:/' in '/............./myproject/node_modules/openapi-framework/dist'

Which comes from exactly this line:

const imported = await import(`file://${fsRoutesItem.path}`);

If I remove the file:// bit, it's alright, but since you actually purposely added this, I don't want to change it.

Thanks!

The Windows version of Node.js requires absolute paths when loading ES modules - in contrast to Linux-based OSes and MacOS which also accept a relative path.

At this point, it could be worth to have a special treatment for Windows-based machines.

Which machine and which version of Node.js are you running?

[7mllm7]

@robertkiel thanks for your reply.
I'm running macOS Monterey (12.4) and Node.js v14.19.2.

Any idea how I can avoid this error without forking 🤔?

Thanks!

[robertkiel]

Probably upgrade to Node.js 16

[coryasilva]

This should have been handled as @7mllm7 suggested.

This change is breaking our jest tests.

Node 20
Mac local dev
Linux container
```