Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi-type: strictly define ResponsesObject type #743

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

mirceanis
Copy link
Contributor

fixes #742

This PR enables strict mode for typescript.
Impressively, the project only has one issue that doesn't work in strict mode, and this PR also fixes that.
You can check this quickly by running npx lerna run prepare which eventually runs tsc.

Strict mode (and this fix) is required by our project which depends directly on openapi-types, so your review of this and eventual release is much appreciated.

  • I only have 1 commit.
  • My commit is prefixed with the relevant package (e.g. express-openapi: fixing something) Note: You can use the bin/commit script to automate this.
  • I have added tests.
    • not explicitly a test, but npx lerna run prepare will demonstrate that the strict compilation works properly
  • I'm using the latest code from the master branch and there are no conflicts on my branch.
  • I have added a suffix to my commit message (fixes Property 'default' of type 'Response | undefined' is not assignable to string index type 'Response' #742)
  • My tests pass locally.
  • I have run linting against my code.

@floriank
Copy link

Thank you for this PR <3

I don't wish to be pushy - but I could really use this change as this currently blocks a project of mine. Any possible ETA on the next release?

@jsdevel
Copy link
Contributor

jsdevel commented Jun 1, 2021

@mirceanis please update with the latest from master.

@mirceanis
Copy link
Contributor Author

@mirceanis please update with the latest from master.

I've rebased my changes onto the latest master
Please re-review

@Morl99
Copy link

Morl99 commented Jun 11, 2021

We would also love to get this issue fixed. Is there anything we could do to help?

@Kosta-Github
Copy link

ping... any updates on this?

@jsdevel jsdevel merged commit 1502d62 into kogosoftwarellc:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'default' of type 'Response | undefined' is not assignable to string index type 'Response'
5 participants