Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter (again) #276

Merged
merged 15 commits into from
Dec 20, 2018
Merged

Linter (again) #276

merged 15 commits into from
Dec 20, 2018

Conversation

bill-kitsune
Copy link
Contributor

Sorry for the double PR but after you merged in the last one I realized there was an issue with the glob pattern I was using. The issue was that I was allowing it to use the shell glob which is not recursive. So I ended up missing any files that were in a sub-directory of a package. I.e. if a package has a src, or test directory.

Changing "lint": "tslint ./packages/**/*.[j,t]s", to "lint": "tslint './packages/**/*.[j,t]s'", solved that an opened up a much larger can of unlinted files for me to tackle...

A couple of other things that are good to be aware of:
The follow section in tslint.json controls which files to ignore. So if there are any I've missed please let me know, or add them as needed.

    "exclude": [
      "**/node_modules/**/*",
      "**/coverage/**/*",
      "**/.nyc_output/**/*",
      "**/dist/**/*",
      "**/docs/**/*",
      "packages/fetch-openapi/test/**/output.js"
    ]
  },

Without re-writing fetch-openapi, or running it's output through prettier it seemed easiest to just ignore the output files for now, I didn't want to add more than was necessary to the scope of this PR because there is already a lot of files changed.

@jsdevel
Copy link
Contributor

jsdevel commented Dec 20, 2018

Without re-writing fetch-openapi, or running it's output through prettier it seemed easiest to just ignore the output files for now, I didn't want to add more than was necessary to the scope of this PR because there is already a lot of files changed.

yea, that package should get re-written at some point to rely on fn.toString instead of concatenating strings (problem for a different day).

@jsdevel jsdevel merged commit 88f9aa0 into kogosoftwarellc:master Dec 20, 2018
@jsdevel
Copy link
Contributor

jsdevel commented Dec 20, 2018

you've been kicking some major butt chuck norris style @bill-kitsune ! thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants