Feature.coordinate display selectors #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 30, 2020 15:45
these will always order the displays by the x or y coordinate of their centre point.
if an invalid index creeps through, returning 0 just means all elements will be considered equal.
and fix an off-by-one error that was causing the last element to not be included in the sort
|
As mentioned in the original issue, I'm not a fan of the kind of selector this implements and so I'll be closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #550 .
Adds
x:<number>andy:<number>as valid display selectors, which will indicate a display based on its horizontal or vertical position.For now the numbers must be positive.