Fail when invalid values are provided to rule arguments. #352
Conversation
|
Now properly tells me I am dumb when using arguments incorrectly: |
| @@ -1764,30 +1769,45 @@ static void handle_domain_rule(FILE *rsp, struct token domain, char *message) | |||
| rule->manage = RULE_PROP_ON; | |||
| } else if (string_equals(value, ARGUMENT_COMMON_VAL_OFF)) { | |||
| rule->manage = RULE_PROP_OFF; | |||
| } else { | |||
| bad_rule_argument_value(rsp, key, value); | |||
| return; | |||
There was a problem hiding this comment.
I noticed there is a mix of having an internal value in the object saying it's OK (for regex in many cases) and early return on failure. Not sure which pattern is preferred, can update this to match other pattern, just let me know.
|
I appreciate the effort, but as you mentioned there is actually not a clear way to properly deal with errors regarding invalid arguments as of right now. Usually I'd agree with something similar to what you did in this PR, but I think I want to rework how rules (and signals) are parsed into something that can validate the value given to key-value pairs, and also whether the key-value pair is required or optional. |
|
Didn't bother too much with what I wrote in my previous comment, but solved it in a way I'm fairly ok with for now. |
Inspired by #350.