Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emacs window border #788

Closed
yshym opened this issue Jan 7, 2021 · 4 comments
Closed

Emacs window border #788

yshym opened this issue Jan 7, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@yshym
Copy link

yshym commented Jan 7, 2021

I have yabai -m rule --add app="^Emacs$" space=code manage=on line in my yabairc and Emacs is successfully managed by yabai, but if i enable window borders, Emacs doesn't have one. Is it possible without macport?

@bashu
Copy link

bashu commented Jan 13, 2021

I second that

@templateK
Copy link

FYI, emacs-mac displays the border when the option is enabled.

@koekeishiya
Copy link
Owner

Note to self: "malformed" windows that are made manageable through rules should be whitelisted for borders (and other similar properties).

@koekeishiya koekeishiya added the bug Something isn't working label May 6, 2021
@vespakoen
Copy link

I added this to src/window.c:

diff --git a/src/window.c b/src/window.c
index 8ef484e..cbf7785 100644
--- a/src/window.c
+++ b/src/window.c
@@ -384,6 +384,8 @@ bool window_level_is_standard(struct window *window)

 bool window_is_standard(struct window *window)
 {
+    if (window->rule_manage) return true;
+
     bool standard_win = false;
     CFStringRef role  = NULL;
     CFStringRef srole = NULL;

Probably not the ideal fix, but works for me, I use it for Adobe After Effects like this:

yabai -m rule --add app="^Adobe After Effects*" manage=on border=on

koekeishiya added a commit that referenced this issue Jul 28, 2021
… for opacity, focus-follows-mouse, and borders
@koekeishiya koekeishiya added the the-future I never think of the future - it comes soon enough. label Jul 28, 2021
@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Nov 18, 2021
@koekeishiya koekeishiya removed addressed on master; not released Fixed upstream, but not yet released the-future I never think of the future - it comes soon enough. labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants