macOS 10.15.4 beta has changes to Dock.app #404

dominiklohmann · 2020-02-05T20:58:49Z

Bug Report

Dock.app seems to have changed on 10.15.4 beta (compared to 10.15.3). As a result, the scripting addition does not currently work on the beta.

It doesn't look like there are any changes to SkyLight.framework, but I've attached it for completeness anyways.

I'm not sure if it makes sense to fix this for beta 1 already, but I suppose it's always better to fix this early so people have time to update yabai before macOS 10.15.4 is released.

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.4
BuildVersion:	19E224g

Attachments

The text was updated successfully, but these errors were encountered:

koekeishiya · 2020-02-05T21:05:50Z

Can you run with the verbose flag and let me know the attrib value that is printed

…

Sent from my iPhone On 5 Feb 2020, at 21:58, Dominik Lohmann <[email protected]> wrote: Bug Report Dock.app seems to have changed on 10.15.4 beta (compared to 10.15.3). As a result, the scripting addition does not currently work on the beta. It doesn't look like there are any changes to SkyLight.framework, but I've attached it for completeness anyways. I'm not sure if it makes sense to fix this for beta 1 already, but I suppose it's always better to fix this early so people have time to update yabai before macOS 10.15.4 is released. $ sw_vers ProductName: Mac OS X ProductVersion: 10.15.4 BuildVersion: 19E224g Attachments * Dock.app.zip<https://github.com/koekeishiya/yabai/files/4161982/Dock.app.zip> * SkyLight.framework.zip<https://github.com/koekeishiya/yabai/files/4161987/SkyLight.framework.zip> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#404?email_source=notifications&email_token=ABPDZV5CKWTAAW7ZHTYLNWDRBMSAXA5CNFSM4KQR6DD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ILKOW2Q>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABPDZVYANCJJBKAW6D2IBWTRBMSAXANCNFSM4KQR6DDQ>.

dominiklohmann · 2020-02-05T21:09:01Z

It's 0, sadly.

yabai: osax version = 1.0.8, osax attrib = 0x0

hexfinder · 2020-02-05T23:40:48Z

get_dock_spaces_pattern

old

__text:0000000100008F8B 48 8D 1D F6 58 48 00                    lea     rbx, unk_10048E888
__text:0000000100008F92 48 8B 3B                                mov     rdi, [rbx]
__text:0000000100008F95 48 8B 35 74 EA 45 00                    mov     rsi, cs:selRef_currentSpaceForDisplay_
__text:0000000100008F9C 44 89 F2                                mov     edx, r14d
__text:0000000100008F9F 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:0000000100008FA2 48 89 C7                                mov     rdi, rax
__text:0000000100008FA5 E8 88 5E 37 00                          call    _objc_retainAutoreleasedReturnValue
__text:0000000100008FAA 48 89 85 F0 FD FF FF                    mov     [rbp+var_210], rax
__text:0000000100008FB1 48 8B 3D 98 39 46 00                    mov     rdi, cs:classRef_NSMutableArray
__text:0000000100008FB8 E8 EB 5D 37 00                          call    _objc_alloc
__text:0000000100008FBD 4C 8B 35 DC EA 45 00                    mov     r14, cs:selRef_initWithCapacity_
__text:0000000100008FC4 48 89 C7                                mov     rdi, rax
__text:0000000100008FC7 4C 89 F6                                mov     rsi, r14
__text:0000000100008FCA 31 D2                                   xor     edx, edx
__text:0000000100008FCC 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:0000000100008FCF 48 89 85 28 FE FF FF                    mov     [rbp+var_1D8], rax
__text:0000000100008FD6 48 8B 3B                                mov     rdi, [rbx]
__text:0000000100008FD9 48 8B 35 80 2F 46 00                    mov     rsi, cs:selRef_spacesForDisplay_
__text:0000000100008FE0 4C 89 EA                                mov     rdx, r13
__text:0000000100008FE3 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:0000000100008FE6 48 89 C7                                mov     rdi, rax
__text:0000000100008FE9 E8 44 5E 37 00                          call    _objc_retainAutoreleasedReturnValue
__text:0000000100008FEE 4C 89 AD 70 FE FF FF                    mov     [rbp+var_190], r13
__text:0000000100008FF5 49 89 C7                                mov     r15, rax
__text:0000000100008FF8 48 8B 3D A1 39 46 00                    mov     rdi, cs:classRef_NSMutableDictionary
__text:0000000100008FFF E8 A4 5D 37 00                          call    _objc_alloc
__text:0000000100009004 48 89 C3                                mov     rbx, rax
__text:0000000100009007 48 8B 35 1A EA 45 00                    mov     rsi, cs:selRef_count
__text:000000010000900E 4C 89 FF                                mov     rdi, r15
__text:0000000100009011 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:0000000100009014 48 89 DF                                mov     rdi, rbx
__text:0000000100009017 4C 89 F6                                mov     rsi, r14
__text:000000010000901A 48 89 C2                                mov     rdx, rax
__text:000000010000901D 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:0000000100009020 48 89 85 18 FE FF FF                    mov     [rbp+var_1E8], rax
__text:0000000100009027 0F 57 C0                                xorps   xmm0, xmm0
__text:000000010000902A 48 8D 9D 10 FD FF FF                    lea     rbx, [rbp+var_2F0]
__text:0000000100009031 0F 29 43 30                             movaps  xmmword ptr [rbx+30h], xmm0
__text:0000000100009035 0F 29 43 20                             movaps  xmmword ptr [rbx+20h], xmm0
__text:0000000100009039 0F 29 43 10                             movaps  xmmword ptr [rbx+10h], xmm0
__text:000000010000903D 0F 29 03                                movaps  xmmword ptr [rbx], xmm0

new

__text:00000001000088C9 4C 8D 3D F8 9D 46 00                    lea     r15, unk_1004726C8
__text:00000001000088D0 49 8B 3F                                mov     rdi, [r15]
__text:00000001000088D3 48 8B 35 B6 3D 44 00                    mov     rsi, cs:selRef_currentSpaceForDisplay_
__text:00000001000088DA 44 89 B5 40 FE FF FF                    mov     dword ptr [rbp+var_1C0], r14d
__text:00000001000088E1 44 89 F2                                mov     edx, r14d
__text:00000001000088E4 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:00000001000088E7 48 89 C7                                mov     rdi, rax
__text:00000001000088EA E8 75 70 35 00                          call    _objc_retainAutoreleasedReturnValue
__text:00000001000088EF 48 89 85 E8 FD FF FF                    mov     [rbp+var_218], rax
__text:00000001000088F6 48 8B 3D 0B 8D 44 00                    mov     rdi, cs:classRef_NSMutableArray
__text:00000001000088FD E8 D8 6F 35 00                          call    _objc_alloc
__text:0000000100008902 4C 8B 35 17 3E 44 00                    mov     r14, cs:selRef_initWithCapacity_
__text:0000000100008909 48 89 C7                                mov     rdi, rax
__text:000000010000890C 4C 89 F6                                mov     rsi, r14
__text:000000010000890F 31 D2                                   xor     edx, edx
__text:0000000100008911 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:0000000100008914 48 89 85 28 FE FF FF                    mov     [rbp+var_1D8], rax
__text:000000010000891B 49 8B 3F                                mov     rdi, [r15]
__text:000000010000891E 48 8B 35 BB 82 44 00                    mov     rsi, cs:selRef_spacesForDisplay_
__text:0000000100008925 48 89 DA                                mov     rdx, rbx
__text:0000000100008928 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:000000010000892B 48 89 C7                                mov     rdi, rax
__text:000000010000892E E8 31 70 35 00                          call    _objc_retainAutoreleasedReturnValue
__text:0000000100008933 49 89 C7                                mov     r15, rax
__text:0000000100008936 48 8B 3D 1B 8D 44 00                    mov     rdi, cs:classRef_NSMutableDictionary
__text:000000010000893D E8 98 6F 35 00                          call    _objc_alloc
__text:0000000100008942 48 89 C3                                mov     rbx, rax
__text:0000000100008945 48 8B 35 5C 3D 44 00                    mov     rsi, cs:selRef_count
__text:000000010000894C 4C 89 FF                                mov     rdi, r15
__text:000000010000894F 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:0000000100008952 48 89 DF                                mov     rdi, rbx
__text:0000000100008955 4C 89 F6                                mov     rsi, r14
__text:0000000100008958 48 89 C2                                mov     rdx, rax
__text:000000010000895B 41 FF D4                                call    r12 ; __imp__objc_msgSend
__text:000000010000895E 48 89 85 18 FE FF FF                    mov     [rbp+var_1E8], rax
__text:0000000100008965 0F 57 C0                                xorps   xmm0, xmm0
__text:0000000100008968 48 8D 9D 10 FD FF FF                    lea     rbx, [rbp+var_2F0]
__text:000000010000896F 0F 29 03                                movaps  xmmword ptr [rbx], xmm0
__text:0000000100008972 0F 29 43 10                             movaps  xmmword ptr [rbx+10h], xmm0
__text:0000000100008976 0F 29 43 20                             movaps  xmmword ptr [rbx+20h], xmm0
__text:000000010000897A 0F 29 43 30                             movaps  xmmword ptr [rbx+30h], xmm0

get_dppm_pattern

old

__text:00000001000077B5 48 8D 3D 7C 71 48 00                    lea     rdi, qword_10048E938
__text:00000001000077BC 48 89 C6                                mov     rsi, rax
__text:00000001000077BF E8 86 76 37 00                          call    _objc_storeStrong
__text:00000001000077C4 4D 85 F6                                test    r14, r14
__text:00000001000077C7 0F 84 67 06 00 00                       jz      loc_100007E34
__text:00000001000077CD 48 8B 3D 4C 55 46 00                    mov     rdi, cs:classRef_NSDistributedNotificationCenter
__text:00000001000077D4 48 8B 35 A5 00 46 00                    mov     rsi, cs:selRef_defaultCenter
__text:00000001000077DB FF 15 3F 7D 3E 00                       call    cs:__imp__objc_msgSend_ptr
__text:00000001000077E1 48 89 C7                                mov     rdi, rax
__text:00000001000077E4 E8 49 76 37 00                          call    _objc_retainAutoreleasedReturnValue
__text:00000001000077E9 48 89 85 08 FF FF FF                    mov     [rbp+var_F8], rax
__text:00000001000077F0 C7 85 1C FF FF FF 00 00+                mov     [rbp+ismember], 0
__text:00000001000077FA E8 8F 74 37 00                          call    _geteuid
__text:00000001000077FF 48 8D 75 B0                             lea     rsi, [rbp+uu]   ; uu
__text:0000000100007803 89 C7                                   mov     edi, eax        ; uid
__text:0000000100007805 E8 2C 75 37 00                          call    _mbr_uid_to_uuid
__text:000000010000780A 85 C0                                   test    eax, eax
__text:000000010000780C 75 22                                   jnz     short loc_100007830
__text:000000010000780E 48 8D 35 A1 36 3B 00                    lea     rsi, aLocalaccounts ; "localaccounts"
__text:0000000100007815 48 8D 4D C0                             lea     rcx, [rbp+var_40] ; uu
__text:0000000100007819 BA 0D 00 00 00                          mov     edx, 0Dh        ; identifier_size
__text:000000010000781E BF 05 00 00 00                          mov     edi, 5          ; id_type
__text:0000000100007823 E8 08 75 37 00                          call    _mbr_identifier_to_uuid
__text:0000000100007828 85 C0                                   test    eax, eax
__text:000000010000782A 0F 84 29 06 00 00                       jz      loc_100007E59

new

__text:0000000100007111 48 8D 3D 60 B6 46 00                    lea     rdi, qword_100472778
__text:0000000100007118 48 89 C6                                mov     rsi, rax
__text:000000010000711B E8 5C 88 35 00                          call    _objc_storeStrong
__text:0000000100007120 4D 85 F6                                test    r14, r14
__text:0000000100007123 0F 84 67 06 00 00                       jz      loc_100007790
__text:0000000100007129 48 8B 3D A8 A8 44 00                    mov     rdi, cs:classRef_NSDistributedNotificationCenter
__text:0000000100007130 48 8B 35 C9 53 44 00                    mov     rsi, cs:selRef_defaultCenter
__text:0000000100007137 FF 15 8B B8 3C 00                       call    cs:__imp__objc_msgSend_ptr
__text:000000010000713D 48 89 C7                                mov     rdi, rax
__text:0000000100007140 E8 1F 88 35 00                          call    _objc_retainAutoreleasedReturnValue
__text:0000000100007145 48 89 85 08 FF FF FF                    mov     [rbp+var_F8], rax
__text:000000010000714C C7 85 1C FF FF FF 00 00+                mov     [rbp+ismember], 0
__text:0000000100007156 E8 65 86 35 00                          call    _geteuid
__text:000000010000715B 48 8D 75 B0                             lea     rsi, [rbp+uu]   ; uu
__text:000000010000715F 89 C7                                   mov     edi, eax        ; uid
__text:0000000100007161 E8 02 87 35 00                          call    _mbr_uid_to_uuid
__text:0000000100007166 85 C0                                   test    eax, eax
__text:0000000100007168 75 22                                   jnz     short loc_10000718C
__text:000000010000716A 48 8D 35 5F 46 39 00                    lea     rsi, aLocalaccounts ; "localaccounts"
__text:0000000100007171 48 8D 4D C0                             lea     rcx, [rbp+var_40] ; uu
__text:0000000100007175 BA 0D 00 00 00                          mov     edx, 0Dh        ; identifier_size
__text:000000010000717A BF 05 00 00 00                          mov     edi, 5          ; id_type
__text:000000010000717F E8 DE 86 35 00                          call    _mbr_identifier_to_uuid
__text:0000000100007184 85 C0                                   test    eax, eax
__text:0000000100007186 0F 84 29 06 00 00                       jz      loc_1000077B5

get_add_space_pattern

old

__text:000000010024B150 55                                      push    rbp
__text:000000010024B151 48 89 E5                                mov     rbp, rsp
__text:000000010024B154 41 57                                   push    r15
__text:000000010024B156 41 56                                   push    r14
__text:000000010024B158 41 55                                   push    r13
__text:000000010024B15A 41 54                                   push    r12
__text:000000010024B15C 53                                      push    rbx
__text:000000010024B15D 48 83 EC 28                             sub     rsp, 28h
__text:000000010024B161 4C 89 6D B8                             mov     [rbp+var_48], r13
__text:000000010024B165 48 BA 01 00 00 00 00 00+                mov     rdx, 4000000000000001h
__text:000000010024B16F 48 B9 F8 FF FF FF FF FF+                mov     rcx, 0FFFFFFFFFFFFF8h
__text:000000010024B179 49 8D 45 28                             lea     rax, [r13+28h]
__text:000000010024B17D 48 89 45 C8                             mov     [rbp+var_38], rax
__text:000000010024B181 4D 8B 7D 28                             mov     r15, [r13+28h]
__text:000000010024B185 41 80 7D 38 01                          cmp     byte ptr [r13+38h], 1
__text:000000010024B18A 48 89 7D C0                             mov     [rbp+var_40], rdi
__text:000000010024B18E 75 5B                                   jnz     short loc_10024B1EB
__text:000000010024B190 49 89 FC                                mov     r12, rdi
__text:000000010024B193 49 85 D7                                test    r15, rdx
__text:000000010024B196 0F 84 A7 00 00 00                       jz      loc_10024B243
__text:000000010024B19C 4C 89 FB                                mov     rbx, r15
__text:000000010024B19F 48 21 CB                                and     rbx, rcx
__text:000000010024B1A2 41 F6 C7 01                             test    r15b, 1
__text:000000010024B1A6 49 0F 45 DF                             cmovnz  rbx, r15
__text:000000010024B1AA 4C 89 FF                                mov     rdi, r15
__text:000000010024B1AD E8 CC 3E 13 00                          call    _swift_bridgeObjectRetain
__text:000000010024B1B2 48 89 DF                                mov     rdi, rbx
__text:000000010024B1B5 E8 3A 23 13 00                          call    _$ss18_CocoaArrayWrapperV8endIndexSivg
__text:000000010024B1BA 49 89 C5                                mov     r13, rax
__text:000000010024B1BD 48 89 DF                                mov     rdi, rbx
__text:000000010024B1C0 E8 2F 23 13 00                          call    _$ss18_CocoaArrayWrapperV8endIndexSivg
__text:000000010024B1C5 49 89 C6                                mov     r14, rax
__text:000000010024B1C8 48 89 DF                                mov     rdi, rbx
__text:000000010024B1CB E8 24 23 13 00                          call    _$ss18_CocoaArrayWrapperV8endIndexSivg
__text:000000010024B1D0 4D 09 EE                                or      r14, r13
__text:000000010024B1D3 0F 88 CF 04 00 00                       js      loc_10024B6A8
__text:000000010024B1D9 4C 39 E8                                cmp     rax, r13
__text:000000010024B1DC 0F 8C C6 04 00 00                       jl      loc_10024B6A8
__text:000000010024B1E2 4C 89 6D D0                             mov     [rbp+var_30], r13
__text:000000010024B1E6 E9 D6 01 00 00                          jmp     loc_10024B3C1

new

__text:000000010023D510 55                                      push    rbp
__text:000000010023D511 48 89 E5                                mov     rbp, rsp
__text:000000010023D514 41 57                                   push    r15
__text:000000010023D516 41 56                                   push    r14
__text:000000010023D518 41 55                                   push    r13
__text:000000010023D51A 41 54                                   push    r12
__text:000000010023D51C 53                                      push    rbx
__text:000000010023D51D 48 83 EC 28                             sub     rsp, 28h
__text:000000010023D521 4C 89 6D C0                             mov     [rbp+var_40], r13
__text:000000010023D525 48 89 7D C8                             mov     [rbp+var_38], rdi
__text:000000010023D529 48 B9 01 00 00 00 00 00+                mov     rcx, 4000000000000001h
__text:000000010023D533 49 BE F8 FF FF FF FF FF+                mov     r14, 0FFFFFFFFFFFFF8h
__text:000000010023D53D 49 8D 45 28                             lea     rax, [r13+28h]
__text:000000010023D541 48 89 45 D0                             mov     [rbp+var_30], rax
__text:000000010023D545 4D 8B 7D 28                             mov     r15, [r13+28h]
__text:000000010023D549 41 80 7D 38 01                          cmp     byte ptr [r13+38h], 1
__text:000000010023D54E 75 2B                                   jnz     short loc_10023D57B
__text:000000010023D550 49 85 CF                                test    r15, rcx
__text:000000010023D553 74 59                                   jz      short loc_10023D5AE
__text:000000010023D555 4C 89 FB                                mov     rbx, r15
__text:000000010023D558 4C 21 F3                                and     rbx, r14
__text:000000010023D55B 41 F6 C7 01                             test    r15b, 1
__text:000000010023D55F 49 0F 45 DF                             cmovnz  rbx, r15
__text:000000010023D563 4C 89 FF                                mov     rdi, r15
__text:000000010023D566 E8 51 26 12 00                          call    _swift_bridgeObjectRetain
__text:000000010023D56B 48 89 DF                                mov     rdi, rbx
__text:000000010023D56E E8 9B 0A 12 00                          call    _$ss18_CocoaArrayWrapperV8endIndexSivg
__text:000000010023D573 49 89 C4                                mov     r12, rax
__text:000000010023D576 E9 A5 01 00 00                          jmp     loc_10023D720

get_remove_space_pattern

old

__text:0000000100340F60 55                                      push    rbp
__text:0000000100340F61 48 89 E5                                mov     rbp, rsp
__text:0000000100340F64 41 57                                   push    r15
__text:0000000100340F66 41 56                                   push    r14
__text:0000000100340F68 41 55                                   push    r13
__text:0000000100340F6A 41 54                                   push    r12
__text:0000000100340F6C 53                                      push    rbx
__text:0000000100340F6D 48 81 EC B8 00 00 00                    sub     rsp, 0B8h
__text:0000000100340F74 49 89 CF                                mov     r15, rcx
__text:0000000100340F77 48 89 55 80                             mov     [rbp+var_80], rdx
__text:0000000100340F7B 49 89 F5                                mov     r13, rsi
__text:0000000100340F7E 48 89 7D B8                             mov     [rbp+var_48], rdi
__text:0000000100340F82 48 BB F8 FF FF FF FF FF+                mov     rbx, 0FFFFFFFFFFFFF8h
__text:0000000100340F8C E8 BF 9A F0 FF                          call    sub_10024AA50
__text:0000000100340F91 49 89 C4                                mov     r12, rax
__text:0000000100340F94 48 B8 01 00 00 00 00 00+                mov     rax, 4000000000000001h
__text:0000000100340F9E 49 85 C4                                test    r12, rax
__text:0000000100340FA1 0F 85 AA 05 00 00                       jnz     loc_100341551
__text:0000000100340FA7 4C 21 E3                                and     rbx, r12
__text:0000000100340FAA 4C 8B 73 10                             mov     r14, [rbx+10h]
__text:0000000100340FAE
__text:0000000100340FAE                         loc_100340FAE:                          ; CODE XREF: sub_100340F60+63C↓j
__text:0000000100340FAE 49 83 FE 02                             cmp     r14, 2
__text:0000000100340FB2 0F 8C B6 02 00 00                       jl      loc_10034126E
__text:0000000100340FB8 4C 89 7D 90                             mov     [rbp+var_70], r15
__text:0000000100340FBC 4C 89 AD 50 FF FF FF                    mov     [rbp+var_B0], r13
__text:0000000100340FC3 4C 89 65 88                             mov     [rbp+var_78], r12
__text:0000000100340FC7 48 8D 05 3A EF 13 00                    lea     rax, _OBJC_IVAR_$__TtC4Dock12ManagedSpace_uuid
__text:0000000100340FCE 48 8B 00                                mov     rax, [rax]
__text:0000000100340FD1 48 8B 5D B8                             mov     rbx, [rbp+var_48]
__text:0000000100340FD5 48 8B 0C 03                             mov     rcx, [rbx+rax]
__text:0000000100340FD9 48 89 4D A0                             mov     [rbp+var_60], rcx
__text:0000000100340FDD 4C 8B 64 03 08                          mov     r12, [rbx+rax+8]
__text:0000000100340FE2 48 8D 05 4F D9 14 00                    lea     rax, qword_10048E938
__text:0000000100340FE9 4C 8B 38                                mov     r15, [rax]
__text:0000000100340FEC 4C 8B 35 2D AF 12 00                    mov     r14, cs:selRef_removeSpace_
__text:0000000100340FF3 4C 89 E7                                mov     rdi, r12
__text:0000000100340FF6 E8 83 E0 03 00                          call    _swift_bridgeObjectRetain
__text:0000000100340FFB 4C 89 FF                                mov     rdi, r15        ; void *
__text:0000000100340FFE 4C 89 F6                                mov     rsi, r14        ; char *
__text:0000000100341001 48 89 DA                                mov     rdx, rbx
__text:0000000100341004 E8 0B DE 03 00                          call    _objc_msgSend
__text:0000000100341009 48 8B 05 28 45 14 00                    mov     rax, cs:_OBJC_IVAR_$__TtC4Dock6Spaces__appToSpaceTable
__text:0000000100341010 48 8B 4D 80                             mov     rcx, [rbp+var_80]
__text:0000000100341014 4C 8D 3C 01                             lea     r15, [rcx+rax]
__text:0000000100341018 4C 8B 2C 01                             mov     r13, [rcx+rax]
__text:000000010034101C 48 8B 0D 85 E0 0A 00                    mov     rcx, cs:__swiftEmptyArrayStorage_ptr

new

__text:00000001003252A0 55                                      push    rbp
__text:00000001003252A1 48 89 E5                                mov     rbp, rsp
__text:00000001003252A4 41 57                                   push    r15
__text:00000001003252A6 41 56                                   push    r14
__text:00000001003252A8 41 55                                   push    r13
__text:00000001003252AA 41 54                                   push    r12
__text:00000001003252AC 53                                      push    rbx
__text:00000001003252AD 48 83 EC 48                             sub     rsp, 48h
__text:00000001003252B1 48 89 4D A0                             mov     [rbp+var_60], rcx
__text:00000001003252B5 49 89 D4                                mov     r12, rdx
__text:00000001003252B8 49 89 F5                                mov     r13, rsi
__text:00000001003252BB 49 89 FE                                mov     r14, rdi
__text:00000001003252BE E8 FD 7B F1 FF                          call    sub_10023CEC0
__text:00000001003252C3 48 89 C3                                mov     rbx, rax
__text:00000001003252C6 48 B8 01 00 00 00 00 00+                mov     rax, 4000000000000001h
__text:00000001003252D0 48 85 C3                                test    rbx, rax
__text:00000001003252D3 0F 85 23 03 00 00                       jnz     loc_1003255FC
__text:00000001003252D9 48 B8 F8 FF FF FF FF FF+                mov     rax, 0FFFFFFFFFFFFF8h
__text:00000001003252E3 48 21 D8                                and     rax, rbx
__text:00000001003252E6 4C 8B 78 10                             mov     r15, [rax+10h]
__text:00000001003252EA
__text:00000001003252EA                         loc_1003252EA:                          ; CODE XREF: sub_1003252A0+38B↓j
__text:00000001003252EA 49 83 FF 02                             cmp     r15, 2
__text:00000001003252EE 0F 8C 3F 01 00 00                       jl      loc_100325433
__text:00000001003252F4 4C 89 6D A8                             mov     [rbp+var_58], r13
__text:00000001003252F8 48 89 5D B8                             mov     [rbp+var_48], rbx
__text:00000001003252FC 48 8D 05 0D E5 13 00                    lea     rax, _OBJC_IVAR_$__TtC4Dock12ManagedSpace_uuid
__text:0000000100325303 48 8B 00                                mov     rax, [rax]
__text:0000000100325306 4D 8B 3C 06                             mov     r15, [r14+rax]
__text:000000010032530A 49 8B 5C 06 08                          mov     rbx, [r14+rax+8]
__text:000000010032530F 48 8D 05 62 D4 14 00                    lea     rax, qword_100472778
__text:0000000100325316 48 8B 38                                mov     rdi, [rax]      ; void *
__text:0000000100325319 48 8B 35 80 B8 12 00                    mov     rsi, cs:selRef_removeSpace_ ; char *
__text:0000000100325320 4C 89 75 C8                             mov     [rbp+var_38], r14
__text:0000000100325324 4C 89 F2                                mov     rdx, r14
__text:0000000100325327 E8 1A A6 03 00                          call    _objc_msgSend
__text:000000010032532C 4C 8B 2D 8D 3A 14 00                    mov     r13, cs:_OBJC_IVAR_$__TtC4Dock6Spaces__appToSpaceTable
__text:0000000100325333 4F 8B 34 2C                             mov     r14, [r12+r13]
__text:0000000100325337 48 89 DF                                mov     rdi, rbx
__text:000000010032533A E8 7D A8 03 00                          call    _swift_bridgeObjectRetain
__text:000000010032533F 4C 89 F7                                mov     rdi, r14
__text:0000000100325342 E8 75 A8 03 00                          call    _swift_bridgeObjectRetain
__text:0000000100325347 4C 89 F7                                mov     rdi, r14
__text:000000010032534A 4C 89 FE                                mov     rsi, r15
__text:000000010032534D 48 89 DA                                mov     rdx, rbx
__text:0000000100325350 4C 89 65 D0                             mov     [rbp+var_30], r12
__text:0000000100325354 45 31 E4                                xor     r12d, r12d

get_move_space_pattern

old

__text:000000010032EB50 55                                      push    rbp
__text:000000010032EB51 48 89 E5                                mov     rbp, rsp
__text:000000010032EB54 41 57                                   push    r15
__text:000000010032EB56 41 56                                   push    r14
__text:000000010032EB58 41 55                                   push    r13
__text:000000010032EB5A 41 54                                   push    r12
__text:000000010032EB5C 53                                      push    rbx
__text:000000010032EB5D 48 83 EC 48                             sub     rsp, 48h
__text:000000010032EB61 4C 89 E9                                mov     rcx, r13
__text:000000010032EB64 41 89 D5                                mov     r13d, edx
__text:000000010032EB67 49 89 F4                                mov     r12, rsi
__text:000000010032EB6A 49 89 FE                                mov     r14, rdi
__text:000000010032EB6D 48 8D 1D 9C 13 15 00                    lea     rbx, _OBJC_IVAR_$__TtC4Dock12ManagedSpace_space
__text:000000010032EB74 48 8B 03                                mov     rax, [rbx]
__text:000000010032EB77 4C 8B 3C 07                             mov     r15, [rdi+rax]
__text:000000010032EB7B 4C 89 FF                                mov     rdi, r15
__text:000000010032EB7E 48 89 4D 98                             mov     [rbp+var_68], rcx
__text:000000010032EB82 48 89 CE                                mov     rsi, rcx
__text:000000010032EB85 E8 C6 CD 00 00                          call    sub_10033B950
__text:000000010032EB8A 48 89 55 D0                             mov     [rbp+var_30], rdx
__text:000000010032EB8E 48 89 45 C8                             mov     [rbp+var_38], rax
__text:000000010032EB92 48 85 C0                                test    rax, rax
__text:000000010032EB95 0F 84 97 03 00 00                       jz      loc_10032EF32
__text:000000010032EB9B 48 8D 05 92 F9 15 00                    lea     rax, unk_10048E534
__text:000000010032EBA2 80 38 01                                cmp     byte ptr [rax], 1
__text:000000010032EBA5 75 33                                   jnz     short loc_10032EBDA
__text:000000010032EBA7 4C 8B 7D D0                             mov     r15, [rbp+var_30]
__text:000000010032EBAB 4D 89 FD                                mov     r13, r15
__text:000000010032EBAE 49 83 C5 28                             add     r13, 28h
__text:000000010032EBB2 48 8B 5D C8                             mov     rbx, [rbp+var_38]
__text:000000010032EBB6 48 89 DF                                mov     rdi, rbx
__text:000000010032EBB9 E8 D2 10 F2 FF                          call    sub_10024FC90
__text:000000010032EBBE 48 89 C7                                mov     rdi, rax
__text:000000010032EBC1 FF 15 61 09 0C 00                       call    cs:_objc_release_ptr
__text:000000010032EBC7 48 89 DF                                mov     rdi, rbx
__text:000000010032EBCA 4C 89 E6                                mov     rsi, r12
__text:000000010032EBCD 4D 89 FD                                mov     r13, r15
__text:000000010032EBD0 E8 FB 2C F2 FF                          call    sub_1002518D0
__text:000000010032EBD5 E9 D9 04 00 00                          jmp     loc_10032F0B3

new

__text:0000000100314B00 55                                      push    rbp
__text:0000000100314B01 48 89 E5                                mov     rbp, rsp
__text:0000000100314B04 41 57                                   push    r15
__text:0000000100314B06 41 56                                   push    r14
__text:0000000100314B08 41 55                                   push    r13
__text:0000000100314B0A 41 54                                   push    r12
__text:0000000100314B0C 53                                      push    rbx
__text:0000000100314B0D 48 83 EC 48                             sub     rsp, 48h
__text:0000000100314B11 4C 89 E9                                mov     rcx, r13
__text:0000000100314B14 41 89 D5                                mov     r13d, edx
__text:0000000100314B17 49 89 F6                                mov     r14, rsi
__text:0000000100314B1A 49 89 FF                                mov     r15, rdi
__text:0000000100314B1D 48 8D 1D F4 EC 14 00                    lea     rbx, _OBJC_IVAR_$__TtC4Dock12ManagedSpace_space
__text:0000000100314B24 48 8B 03                                mov     rax, [rbx]
__text:0000000100314B27 4C 8B 24 07                             mov     r12, [rdi+rax]
__text:0000000100314B2B 4C 89 E7                                mov     rdi, r12
__text:0000000100314B2E 48 89 4D A0                             mov     [rbp+var_60], rcx
__text:0000000100314B32 48 89 CE                                mov     rsi, rcx
__text:0000000100314B35 E8 E6 BE 00 00                          call    sub_100320A20
__text:0000000100314B3A 48 85 C0                                test    rax, rax
__text:0000000100314B3D 74 27                                   jz      short loc_100314B66
__text:0000000100314B3F 48 8D 0D 2E D8 15 00                    lea     rcx, unk_100472374
__text:0000000100314B46 80 39 01                                cmp     byte ptr [rcx], 1
__text:0000000100314B49 48 89 55 C8                             mov     [rbp+var_38], rdx
__text:0000000100314B4D 48 89 45 A8                             mov     [rbp+var_58], rax
__text:0000000100314B51 75 1A                                   jnz     short loc_100314B6D
__text:0000000100314B53 48 89 C7                                mov     rdi, rax
__text:0000000100314B56 4C 89 F6                                mov     rsi, r14
__text:0000000100314B59 49 89 D5                                mov     r13, rdx
__text:0000000100314B5C E8 3F D8 F2 FF                          call    sub_1002423A0
__text:0000000100314B61 E9 8B 04 00 00                          jmp     loc_100314FF1

get_set_front_window_pattern

old

__text:0000000100053F37 55                                      push    rbp
__text:0000000100053F38 48 89 E5                                mov     rbp, rsp
__text:0000000100053F3B 41 57                                   push    r15
__text:0000000100053F3D 41 56                                   push    r14
__text:0000000100053F3F 41 55                                   push    r13
__text:0000000100053F41 41 54                                   push    r12
__text:0000000100053F43 53                                      push    rbx
__text:0000000100053F44 48 83 EC 58                             sub     rsp, 58h
__text:0000000100053F48 48 8B 05 D9 AF 39 00                    mov     rax, cs:___stack_chk_guard_ptr
__text:0000000100053F4F 48 8B 00                                mov     rax, [rax]
__text:0000000100053F52 48 89 45 D0                             mov     [rbp+var_30], rax
__text:0000000100053F56 85 F6                                   test    esi, esi
__text:0000000100053F58 0F 84 0A 02 00 00                       jz      loc_100054168
__text:0000000100053F5E 41 89 F5                                mov     r13d, esi
__text:0000000100053F61 49 89 FF                                mov     r15, rdi
__text:0000000100053F64 49 89 FE                                mov     r14, rdi
__text:0000000100053F67 49 C1 EE 20                             shr     r14, 20h
__text:0000000100053F6B 48 8D 75 AF                             lea     rsi, [rbp+var_51]
__text:0000000100053F6F C6 06 00                                mov     byte ptr [rsi], 0
__text:0000000100053F72 E8 87 B6 02 00                          call    sub_10007F5FE
__text:0000000100053F77 48 8B 3D 22 B1 39 00                    mov     rdi, cs:__os_log_default_ptr
__text:0000000100053F7E BE 01 00 00 00                          mov     esi, 1
__text:0000000100053F83 E8 EC AE 32 00                          call    _os_log_type_enabled
__text:0000000100053F88 84 C0                                   test    al, al
__text:0000000100053F8A 74 59                                   jz      short loc_100053FE5
__text:0000000100053F8C 0F B6 5D AF                             movzx   ebx, [rbp+var_51]
__text:0000000100053F90 4C 8D 45 B0                             lea     r8, [rbp+var_50]
__text:0000000100053F94 41 C7 00 00 04 00 04                    mov     dword ptr [r8], 4000400h
__text:0000000100053F9B 45 89 78 04                             mov     [r8+4], r15d
__text:0000000100053F9F 66 B8 00 04                             mov     ax, 400h
__text:0000000100053FA3 66 41 89 40 08                          mov     [r8+8], ax
__text:0000000100053FA8 45 89 70 0A                             mov     [r8+0Ah], r14d
__text:0000000100053FAC 66 41 89 40 0E                          mov     [r8+0Eh], ax
__text:0000000100053FB1 45 89 68 10                             mov     [r8+10h], r13d
__text:0000000100053FB5 66 41 89 40 14                          mov     [r8+14h], ax
__text:0000000100053FBA 41 89 58 16                             mov     [r8+16h], ebx
__text:0000000100053FBE 48 8D 3D 3B C0 FA FF                    lea     rdi, __mh_execute_header
__text:0000000100053FC5 48 8B 35 D4 B0 39 00                    mov     rsi, cs:__os_log_default_ptr

new

__text:00000001000532BF 55                                      push    rbp
__text:00000001000532C0 48 89 E5                                mov     rbp, rsp
__text:00000001000532C3 41 57                                   push    r15
__text:00000001000532C5 41 56                                   push    r14
__text:00000001000532C7 41 55                                   push    r13
__text:00000001000532C9 41 54                                   push    r12
__text:00000001000532CB 53                                      push    rbx
__text:00000001000532CC 48 83 EC 58                             sub     rsp, 58h
__text:00000001000532D0 48 8B 05 F9 F0 37 00                    mov     rax, cs:___stack_chk_guard_ptr
__text:00000001000532D7 48 8B 00                                mov     rax, [rax]
__text:00000001000532DA 48 89 45 D0                             mov     [rbp+var_30], rax
__text:00000001000532DE 85 F6                                   test    esi, esi
__text:00000001000532E0 0F 84 07 02 00 00                       jz      loc_1000534ED
__text:00000001000532E6 41 89 F5                                mov     r13d, esi
__text:00000001000532E9 49 89 FF                                mov     r15, rdi
__text:00000001000532EC 49 89 FE                                mov     r14, rdi
__text:00000001000532EF 49 C1 EE 20                             shr     r14, 20h
__text:00000001000532F3 48 8D 75 AF                             lea     rsi, [rbp+var_51]
__text:00000001000532F7 C6 06 00                                mov     byte ptr [rsi], 0
__text:00000001000532FA E8 27 B4 02 00                          call    sub_10007E726
__text:00000001000532FF 48 8B 3D 42 F2 37 00                    mov     rdi, cs:__os_log_default_ptr
__text:0000000100053306 BE 01 00 00 00                          mov     esi, 1
__text:000000010005330B E8 96 C6 30 00                          call    _os_log_type_enabled
__text:0000000100053310 84 C0                                   test    al, al
__text:0000000100053312 74 59                                   jz      short loc_10005336D
__text:0000000100053314 0F B6 5D AF                             movzx   ebx, [rbp+var_51]
__text:0000000100053318 4C 8D 45 B0                             lea     r8, [rbp+var_50]
__text:000000010005331C 41 C7 00 00 04 00 04                    mov     dword ptr [r8], 4000400h
__text:0000000100053323 45 89 78 04                             mov     [r8+4], r15d
__text:0000000100053327 66 B8 00 04                             mov     ax, 400h
__text:000000010005332B 66 41 89 40 08                          mov     [r8+8], ax
__text:0000000100053330 45 89 70 0A                             mov     [r8+0Ah], r14d
__text:0000000100053334 66 41 89 40 0E                          mov     [r8+0Eh], ax
__text:0000000100053339 45 89 68 10                             mov     [r8+10h], r13d
__text:000000010005333D 66 41 89 40 14                          mov     [r8+14h], ax
__text:0000000100053342 41 89 58 16                             mov     [r8+16h], ebx
__text:0000000100053346 48 8D 3D B3 CC FA FF                    lea     rdi, __mh_execute_header
__text:000000010005334D 48 8B 35 F4 F1 37 00                    mov     rsi, cs:__os_log_default_ptr

koekeishiya · 2020-02-12T15:28:41Z

Will likely require some further changes in the next beta or release, but fixed for now.

dominiklohmann added the bug Something isn't working label Feb 5, 2020

koekeishiya added a commit that referenced this issue Feb 8, 2020

#404 update scripting addition for 10.15.4 Beta

f8cf7e5

koekeishiya added addressed on master; not released Fixed upstream, but not yet released and removed addressed on master; not released Fixed upstream, but not yet released labels Feb 8, 2020

koekeishiya closed this as completed Feb 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

macOS 10.15.4 beta has changes to Dock.app #404

macOS 10.15.4 beta has changes to Dock.app #404

dominiklohmann commented Feb 5, 2020

koekeishiya commented Feb 5, 2020 via email

dominiklohmann commented Feb 5, 2020

hexfinder commented Feb 5, 2020

koekeishiya commented Feb 12, 2020

macOS 10.15.4 beta has changes to Dock.app #404

macOS 10.15.4 beta has changes to Dock.app #404

Comments

dominiklohmann commented Feb 5, 2020

Bug Report

Attachments

koekeishiya commented Feb 5, 2020 via email

dominiklohmann commented Feb 5, 2020

hexfinder commented Feb 5, 2020

get_dock_spaces_pattern

get_dppm_pattern

get_add_space_pattern

get_remove_space_pattern

get_move_space_pattern

get_set_front_window_pattern

koekeishiya commented Feb 12, 2020