-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window server crash on wake when window opacity was changed on Catalina #277
Comments
@dominiklohmann with regards to the Or alternatively, could I keep opacity enabled, but stop the yabai service before putting the computer to sleep? Seems silly that opacity is more important than having my computer be able to go to sleep...but that's where I am. |
I encountered a slight variation of this problem. On wake i've never had a problem, but if i spawned many new windows in a short interval of time (ex. spamming the 'open terminal' keybinding i've set up) the window server would crash and i would be thrown into the login page. One disabled the custom "flash on focus" script i encountered no more crashes. (Each new window would grab focus and trigger the script for a quick decrese/increase of opacity to simulate a flash. Hope this helps (ofc i'm in catalina) |
Is there any progress on this? |
In my case it works when i remove the transition: |
I mean, this is an Apple bug so there is nothing that can be done about it as far as I'm concerned. |
@koekeishiya did you ever get any feedback from Apple regarding report, FB7444639? |
Nope, no response (as expected). I've verified that you can run with opacity on as long as the duration is set to 0, but the fade does make it nicer imo. |
Don't you just love Apple. At this point, I'm using fade (because it's so much nicer) and endure the frequent crashes. It's a shame they haven't addressed it. |
@koekeishiya that's unknown territory for me. I have limited C and system's programming knowledge. I dabble, but not much more than that. Would love to get into it at some point but I never know where to start and I'm missing some positive peer pressure holding me accountable for making real progress. 🙂 |
Today I bump my macOS version into 10.15.5 , and when I restart my yabai service, it reported with the crash (yabai-sa) yabai version: yabai-v3.0.0 |
Upgrade to the latest version of yabai, reinstall the scripting-addition and add |
Thanks , it was fixes after I reinstall from the HEAD . |
The screenshot above is from IDA Pro. Another good tool for macOS is Hopper. -- I've made a patched version of the SkyLight binary for macOS __10.15.4__, although I have not yet had the time to test it. DO NOT ATTEMPT TO USE THIS UNLESS YOU KNOW WHAT YOU ARE DOING and you are capable of getting back to a working system, testing in a VM first is recommended. Patching system binaries require both SIP to be (fully?) disabled and AMFI (Apple Mobile File Integrity) to be disabled.
Diff original -> patched
Backup and replace the SkyLight binary, replace signature:
|
It is no longer possible to set the duration while running on macOS Catalina. |
|
… to an Apple bug in the WindowServer
Could that be made optional? For me the duration is working on Big Sur. |
I am a bit reluctant to do that. The crash is happening at the exact same location as it did on Catalina. It appears to work fine for some time, but when it crashes it literally kills the entire user session. I don't feel good about that being a thing, even if gated by an optional setting. |
any updates here? I miss opacity transitions 😭 |
No changes as far as I know
…Sent from my iPhone
On 18 Aug 2021, at 20:24, Yorke Rhodes ***@***.***> wrote:
any updates here? I miss opacity transitions 😭
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#277 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABPDZV2HPAUBBJ2OFE5SXX3T5P3EFANCNFSM4I63TEJA>.
|
…Big Sur due to an Apple bug in the WindowServer
Implemented window fading manually (on the master branch), instead of relying on the implementation in SkyLight. |
Bug Report
There is a crash happening in
CGXSetWindowListAlpha
on 10.15. It appears to happen on wake if a windows opacity was previously changed, and has been previously discussed as part of #22.For now it is recommended to add
yabai -m config window_opacity_duration 0.0
to your configuration file.Click to expand crash log
The text was updated successfully, but these errors were encountered: