Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a non-zero exit code when a command fails because of an issue with the scripting addition #181

Closed
dominiklohmann opened this issue Aug 1, 2019 · 2 comments
Labels
suggestion Request for new feature or some form of enhancement

Comments

@dominiklohmann
Copy link
Collaborator

Feature request

Return a non-zero exit code if a command fails because the scripting addition is not installed or failed to get addresses.

This would be nice for scripts so chaining with && or set -e fails early. Currently there's no error message printed to stderr and the exit code is 0, indicating success.

@koekeishiya koekeishiya added the suggestion Request for new feature or some form of enhancement label Sep 3, 2019
@koekeishiya
Copy link
Owner

Do you think it is useful as an end-user to be able to tell the difference between the various ways the scripting-addition fails, or is a generic catch-all "the operation could not complete due to an error with the scripting addition" good enough (with a non-zero exit code of course).

@dominiklohmann
Copy link
Collaborator Author

dominiklohmann commented Mar 4, 2020

If I recall correctly I wanted to write this in some place:

yabai -m space --focus 1 || skhd --key "ctrl - 1"

So just failing with a generic code is enough.

koekeishiya pushed a commit that referenced this issue Nov 12, 2020
koekeishiya added a commit that referenced this issue Nov 15, 2020
koekeishiya added a commit that referenced this issue Nov 15, 2020
@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Nov 15, 2020
@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Dec 3, 2020
unrevre pushed a commit to unrevre/yabai that referenced this issue Jan 26, 2022
unrevre pushed a commit to unrevre/yabai that referenced this issue Jan 26, 2022
unrevre pushed a commit to unrevre/yabai that referenced this issue Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Request for new feature or some form of enhancement
Projects
None yet
Development

No branches or pull requests

2 participants