Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warping windows does not always respect specified insert direction #146

Closed
dominiklohmann opened this issue Jul 18, 2019 · 2 comments
Closed

Warping windows does not always respect specified insert direction #146

dominiklohmann opened this issue Jul 18, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@dominiklohmann
Copy link
Collaborator

Bug report

A mix of yabai -m window $1 --insert <dir_sel> and yabai -m window $2 --warp $1 does not work if window $1 is a direct child or parent node of window $2.

Instead it simply swaps the windows.

The behaviour is probably in place because for this scenario a warp is a swap, but when an insert direction is given it should always warp.
@koekeishiya
Copy link
Owner

Your assumption is correct.

@koekeishiya koekeishiya added the bug Something isn't working label Jul 24, 2019
koekeishiya added a commit that referenced this issue Jul 30, 2019
@koekeishiya
#146 window warp should respect insert direction in situations where …
3d315c0 
…a default warp would equal a swap
@koekeishiya
Copy link
Owner

Fixed on master.

@koekeishiya koekeishiya added the addressed on master; not released Fixed upstream, but not yet released label Jul 30, 2019
@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominiklohmann @koekeishiya