Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new stack doesn't update the ID of the visible window #1311

Closed
diocletiann opened this issue Jun 19, 2022 · 6 comments
Closed

Creating a new stack doesn't update the ID of the visible window #1311

diocletiann opened this issue Jun 19, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@diocletiann
Copy link

diocletiann commented Jun 19, 2022

When a new stack is created, the new visible topmost window ID doesn't seem to get updated. So when the stack is focused the first time, the hidden window surfaces and you have to re-focus the correct window. You can reproduce by creating a new stack then querying in its direction, screenshots below. Thanks!

Screen Shot 2022-06-19 at 3 51 38 PM

Screen Shot 2022-06-19 at 3 54 15 PM

@diocletiann
Copy link
Author

Found a workaround, if you send a stack.prev and stack.next after creating a new stack it refreshes the IDs. Next time you focus the stack the windows don't flip.

@diocletiann
Copy link
Author

diocletiann commented Sep 20, 2022

@koekeishiya wanted to put this on your radar in case it's a simple fix. Thanks!

@koekeishiya
Copy link
Owner

This ordering issue happens when adding a non-focused window to a stack, correct? So the window that yabai says is top of the stack, is not actually the topmost window on screen?

@diocletiann
Copy link
Author

diocletiann commented Sep 21, 2022

This ordering issue happens when adding a non-focused window to a stack, correct? So the window that yabai says is top of the stack, is not actually the topmost window on screen?

I'm stacking like this: yabai -m window west --stack 'focused window id' while the window is focused. But if you then query the ID of the window you just stacked from a third window, it's not the same.

Then when you try to focus this stack for the first time, it will cycle the topmost window and surface the one below. I can issue window --focus stack.next && window --focus stack.prev right after the stack command which seems to fix the IDs.

@koekeishiya
Copy link
Owner

Should be fixed on master.

@koekeishiya koekeishiya added bug Something isn't working addressed on master; not released Fixed upstream, but not yet released labels Sep 22, 2022
@diocletiann
Copy link
Author

Should be fixed on master.

Confirmed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants